Extracts an TargetX86Base target which will be used as the common X86{32,64} implementation.

src/IceInst.h

 //===- subzero/src/IceInst.h - High-level instructions ----------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file declares the Inst class and its target-independent
 // subclasses, which represent the high-level Vanilla ICE instructions
 // and map roughly 1:1 to LLVM instructions.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef SUBZERO_SRC_ICEINST_H
 #define SUBZERO_SRC_ICEINST_H
 
+#include "IceCfg.h"

[Jim Stichnoth, 2015/06/22 21:52:02]

Is this include actually needed?

[John, 2015/06/22 22:09:23]

Yes, it is. This header uses

Func->...

which means Cfg needs to be defined (not just declared.)

[Jim Stichnoth, 2015/06/22 23:04:05]

I see.  Looks like we've just gotten lucky so far.

 #include "IceDefs.h"
 #include "IceInst.def"
 #include "IceIntrinsics.h"
 #include "IceTypes.h"
 
 // TODO: The Cfg structure, and instructions in particular, need to be
 // validated for things like valid operand types, valid branch
 // targets, proper ordering of Phi and non-Phi instructions, etc.
 // Most of the validity checking will be done in the bitcode reader.
 // We need a list of everything that should be validated, and tests
@@ skipping 906 matching lines @@
   static void noteHead(Ice::Inst *, Ice::Inst *) {}
   void deleteNode(Ice::Inst *) {}
 
 private:
   mutable ilist_half_node<Ice::Inst> Sentinel;
 };
 
 } // end of namespace llvm
 
 #endif // SUBZERO_SRC_ICEINST_H