Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp

Issue 1202523006: SP: Invalidate all non-compositing descendants in the slow scroll path. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/paint/invalidation/non-stacking-scroller-with-abspos-descendant-expected.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 } 417 }
418 418
419 // Only the root layer can overlap non-composited fixed-position elements. 419 // Only the root layer can overlap non-composited fixed-position elements.
420 if (!requiresPaintInvalidation && layer()->isRootLayer() && frameView->hasVi ewportConstrainedObjects()) { 420 if (!requiresPaintInvalidation && layer()->isRootLayer() && frameView->hasVi ewportConstrainedObjects()) {
421 if (!frameView->invalidateViewportConstrainedObjects()) 421 if (!frameView->invalidateViewportConstrainedObjects())
422 requiresPaintInvalidation = true; 422 requiresPaintInvalidation = true;
423 } 423 }
424 424
425 // Just schedule a full paint invalidation of our object. 425 // Just schedule a full paint invalidation of our object.
426 // FIXME: This invalidation will be unnecessary in slimming paint phase 2. 426 // FIXME: This invalidation will be unnecessary in slimming paint phase 2.
427 if (requiresPaintInvalidation) 427 if (requiresPaintInvalidation) {
428 box().setShouldDoFullPaintInvalidation(); 428 if (RuntimeEnabledFeatures::slimmingPaintEnabled())
429 box().setShouldDoFullPaintInvalidationIncludingNonCompositingDescend ants();
430 else
431 box().setShouldDoFullPaintInvalidation();
432 }
429 433
430 // Schedule the scroll DOM event. 434 // Schedule the scroll DOM event.
431 if (box().node()) 435 if (box().node())
432 box().node()->document().enqueueScrollEventForNode(box().node()); 436 box().node()->document().enqueueScrollEventForNode(box().node());
433 437
434 if (AXObjectCache* cache = box().document().existingAXObjectCache()) 438 if (AXObjectCache* cache = box().document().existingAXObjectCache())
435 cache->handleScrollPositionChanged(&box()); 439 cache->handleScrollPositionChanged(&box());
436 box().view()->clearHitTestCache(); 440 box().view()->clearHitTestCache();
437 } 441 }
438 442
(...skipping 950 matching lines...) Expand 10 before | Expand all | Expand 10 after
1389 void DeprecatedPaintLayerScrollableArea::setTopmostScrollChild(DeprecatedPaintLa yer* scrollChild) 1393 void DeprecatedPaintLayerScrollableArea::setTopmostScrollChild(DeprecatedPaintLa yer* scrollChild)
1390 { 1394 {
1391 // We only want to track the topmost scroll child for scrollable areas with 1395 // We only want to track the topmost scroll child for scrollable areas with
1392 // overlay scrollbars. 1396 // overlay scrollbars.
1393 if (!hasOverlayScrollbars()) 1397 if (!hasOverlayScrollbars())
1394 return; 1398 return;
1395 m_nextTopmostScrollChild = scrollChild; 1399 m_nextTopmostScrollChild = scrollChild;
1396 } 1400 }
1397 1401
1398 } // namespace blink 1402 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/paint/invalidation/non-stacking-scroller-with-abspos-descendant-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698