Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Issue 1202523005: Disable a flaky test (Closed)

Created:
5 years, 6 months ago by Dan Ehrenberg
Modified:
5 years, 6 months ago
Reviewers:
erikcorry, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable a flaky test This test starts failing when the --harmony-array flag is turned on, but the failure does not directly have to do with that flag. Disabling the test in debug mode to unblock the release. BUG=v8:4237 LOG=n R=adamk,erikcorry Committed: https://crrev.com/29c4904c0a9c7b4badf13e7ee744d7ec392fb9b9 Cr-Commit-Position: refs/heads/master@{#29207}

Patch Set 1 #

Total comments: 2

Patch Set 2 : always skip in gc stress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Dan Ehrenberg
5 years, 6 months ago (2015-06-22 21:54:20 UTC) #1
adamk
https://codereview.chromium.org/1202523005/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1202523005/diff/1/test/mjsunit/mjsunit.status#newcode300 test/mjsunit/mjsunit.status:300: 'regress/regress-3976': [PASS, ['mode == debug', SKIP]], Might as well ...
5 years, 6 months ago (2015-06-22 21:56:46 UTC) #2
Dan Ehrenberg
https://codereview.chromium.org/1202523005/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/1202523005/diff/1/test/mjsunit/mjsunit.status#newcode300 test/mjsunit/mjsunit.status:300: 'regress/regress-3976': [PASS, ['mode == debug', SKIP]], On 2015/06/22 21:56:46, ...
5 years, 6 months ago (2015-06-22 22:05:44 UTC) #3
adamk
lgtm
5 years, 6 months ago (2015-06-22 22:09:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202523005/20001
5 years, 6 months ago (2015-06-22 22:09:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 22:37:34 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 22:38:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29c4904c0a9c7b4badf13e7ee744d7ec392fb9b9
Cr-Commit-Position: refs/heads/master@{#29207}

Powered by Google App Engine
This is Rietveld 408576698