Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1202523004: Make WebViewGuest::LoadURLWithParams also take a GlobalRequestID param. (Closed)

Created:
5 years, 6 months ago by lazyboy
Modified:
5 years, 6 months ago
Reviewers:
lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebViewGuest::LoadURLWithParams also take a GlobalRequestID param. This param can be used to construct "transferred_global_request_id" field of NavigationController::LoadURLParams. Currently this is no-op but this is a requirement for OOPIF based <webview> implementation. BUG=330264 Test=None, internal change. Committed: https://crrev.com/b7fd358fc121acce20e55ee20a81ce0597c2ca0b Cr-Commit-Position: refs/heads/master@{#335638}

Patch Set 1 #

Patch Set 2 : SYNC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M extensions/browser/guest_view/web_view/web_view_guest.h View 2 chunks +10 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
lazyboy
5 years, 6 months ago (2015-06-22 21:29:31 UTC) #2
lfg
lgtm
5 years, 6 months ago (2015-06-22 21:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202523004/1
5 years, 6 months ago (2015-06-22 22:10:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/30816)
5 years, 6 months ago (2015-06-22 23:07:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202523004/1
5 years, 6 months ago (2015-06-22 23:34:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/30886)
5 years, 6 months ago (2015-06-23 00:11:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202523004/1
5 years, 6 months ago (2015-06-23 02:24:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/70729)
5 years, 6 months ago (2015-06-23 02:59:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202523004/20001
5 years, 6 months ago (2015-06-23 04:29:49 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/31042)
5 years, 6 months ago (2015-06-23 05:05:59 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202523004/20001
5 years, 6 months ago (2015-06-23 05:59:50 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-23 06:20:24 UTC) #23
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 06:21:24 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7fd358fc121acce20e55ee20a81ce0597c2ca0b
Cr-Commit-Position: refs/heads/master@{#335638}

Powered by Google App Engine
This is Rietveld 408576698