Android: removes "trace_event_clock_sync" from atrace.

Android: removes "trace_event_clock_sync" from atrace.

This event was written to debugfs when trace was finished.
It happens on the UI thread and IO is not allowed.

BUG=170284
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177764

[bulach, 2013-01-18 11:07:58]

nduca: is this what you meant in https://codereview.chromium.org/11931015/ ?

wangxianzhu: I'm not sure what are all the implications here, please let me know
if this is fine.

[nduca, 2013-01-18 13:46:38]

That's right. LGTM.

In the dawn of time, the way we got systrace style data from android that
contained both chrome info and also kernel info was by recording two complete
traces --- one from the kernel, and one from chrome. We'd then align the two
trace recordings' timestamps when parsing them in the UI. It made it work, and
got the android guys to build systrace. But its like mega awk.

So lets like not do it. :) We've got systrace.

[bulach, 2013-01-18 14:22:19]

great, thanks for the detailed explanation!

CQing..

[commit-bot: I haz the power, 2013-01-18 14:25:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/12025014/1

[commit-bot: I haz the power, 2013-01-18 14:25:36]

Presubmit check for 12025014-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    base

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[bulach, 2013-01-18 14:30:45]

+willchan for base/OWNER

[nduca, 2013-01-18 14:36:07]

@jar may be able to review as well, we typically terrorize him with trace_event
reviews. :)

[willchan no longer on Chromium, 2013-01-18 16:59:58]

LGTM, although if you can delete these #includes too, that'd be great.

https://chromiumcodereview.appspot.com/12025014/diff/1/base/debug/trace_event...
File base/debug/trace_event_android.cc (right):

https://chromiumcodereview.appspot.com/12025014/diff/1/base/debug/trace_event...
base/debug/trace_event_android.cc:10: #include "base/file_util.h"
Can we delete this too?

https://chromiumcodereview.appspot.com/12025014/diff/1/base/debug/trace_event...
base/debug/trace_event_android.cc:11: #include "base/format_macros.h"
Not clear to me why this is necessary

[bulach, 2013-01-18 19:24:28]

thanks will! good catch, removed the spurious #include..

https://chromiumcodereview.appspot.com/12025014/diff/1/base/debug/trace_event...
File base/debug/trace_event_android.cc (right):

https://chromiumcodereview.appspot.com/12025014/diff/1/base/debug/trace_event...
base/debug/trace_event_android.cc:10: #include "base/file_util.h"
On 2013/01/18 16:59:58, willchan wrote:
> Can we delete this too?

Done.

https://chromiumcodereview.appspot.com/12025014/diff/1/base/debug/trace_event...
base/debug/trace_event_android.cc:11: #include "base/format_macros.h"
On 2013/01/18 16:59:58, willchan wrote:
> Not clear to me why this is necessary

Done.

[commit-bot: I haz the power, 2013-01-18 19:24:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/12025014/9001

[commit-bot: I haz the power, 2013-01-18 21:45:08]

Change committed as 177764