chrome/common/extensions/manifest_handler.cc - Issue 12025010: Move default_locale out of Extension class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handler.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: extension_service_unittest fixed Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/manifest_handler.cc

diff --git a/chrome/common/extensions/manifest_handler.cc b/chrome/common/extensions/manifest_handler.cc

index 9d2a9b5502773421f5965afeb9f80470f50365ab..ce214ebdecd487a8f2a8de7b2f1982498b3ff80d 100644

--- a/chrome/common/extensions/manifest_handler.cc

+++ b/chrome/common/extensions/manifest_handler.cc

@@ -41,7 +41,7 @@ bool ManifestHandlerRegistry::ParseExtension(Extension* extension,

ManifestHandler* handler = iter->second.get();

if (extension->manifest()->HasPath(iter->first) ||

handler->AlwaysParseForType(extension->GetType()))

- handler_set.insert(iter->second.get());

+ handler_set.insert(handler);

}

// TODO(yoz): Some handlers may depend on other handlers having already