Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/common/extensions/extension.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extension_service_unittest fixed Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 97f67a974e32fdad6692f85e8b848d1b70c97b77..c64e0bb07c3a4b1babf6238081a948f5538c1b96 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -1927,7 +1927,6 @@ bool Extension::LoadSharedFeatures(
!LoadNaClModules(error) ||
!LoadSandboxedPages(error) ||
!LoadRequirements(error) ||
- !LoadDefaultLocale(error) ||
!LoadOfflineEnabled(error) ||
// LoadBackgroundScripts() must be called before LoadBackgroundPage().
!LoadBackgroundScripts(error) ||
@@ -2212,17 +2211,6 @@ bool Extension::LoadRequirements(string16* error) {
return true;
}
-bool Extension::LoadDefaultLocale(string16* error) {
- if (!manifest_->HasKey(keys::kDefaultLocale))
- return true;
- if (!manifest_->GetString(keys::kDefaultLocale, &default_locale_) ||
- !l10n_util::IsValidLocaleSyntax(default_locale_)) {
- *error = ASCIIToUTF16(errors::kInvalidDefaultLocale);
- return false;
- }
- return true;
-}
-
bool Extension::LoadOfflineEnabled(string16* error) {
// Defaults to false, except for platform apps which are offline by default.
if (!manifest_->HasKey(keys::kOfflineEnabled)) {
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698