Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10106)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_default_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc
similarity index 68%
rename from chrome/common/extensions/manifest_tests/extension_manifests_default_unittest.cc
rename to chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc
index 959a161de49f9601b81cf65beb7eb23bbd92a37e..7f4ea076dba5548b4e3811279c368bb8685967f2 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_default_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc
@@ -2,14 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
#include "testing/gtest/include/gtest/gtest.h"
-namespace errors = extension_manifest_errors;
-
TEST_F(ExtensionManifestTest, DefaultPathForExtent) {
scoped_refptr<extensions::Extension> extension(
LoadAndExpectSuccess("default_path_for_extent.json"));
@@ -19,12 +16,3 @@ TEST_F(ExtensionManifestTest, DefaultPathForExtent) {
EXPECT_TRUE(extension->web_extent().MatchesURL(
GURL("http://www.google.com/monkey")));
}
-
-TEST_F(ExtensionManifestTest, DefaultLocale) {
- LoadAndExpectError("default_locale_invalid.json",
- errors::kInvalidDefaultLocale);
-
- scoped_refptr<extensions::Extension> extension(
- LoadAndExpectSuccess("default_locale_valid.json"));
- EXPECT_EQ("de-AT", extension->default_locale());
-}

Powered by Google App Engine
This is Rietveld 408576698