Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/common/extensions/unpacker.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: extension_service_unittest fixed Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/unpacker.h" 5 #include "chrome/common/extensions/unpacker.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/file_util.h" 9 #include "base/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 10 #include "base/files/scoped_temp_dir.h"
11 #include "base/i18n/rtl.h" 11 #include "base/i18n/rtl.h"
12 #include "base/json/json_file_value_serializer.h" 12 #include "base/json/json_file_value_serializer.h"
13 #include "base/memory/scoped_handle.h" 13 #include "base/memory/scoped_handle.h"
14 #include "base/string_util.h" 14 #include "base/string_util.h"
15 #include "base/threading/thread.h" 15 #include "base/threading/thread.h"
16 #include "base/utf_string_conversions.h" 16 #include "base/utf_string_conversions.h"
17 #include "base/values.h" 17 #include "base/values.h"
18 #include "chrome/common/extensions/api/i18n/default_locale_handler.h"
18 #include "chrome/common/extensions/extension.h" 19 #include "chrome/common/extensions/extension.h"
19 #include "chrome/common/extensions/extension_file_util.h" 20 #include "chrome/common/extensions/extension_file_util.h"
20 #include "chrome/common/extensions/extension_l10n_util.h" 21 #include "chrome/common/extensions/extension_l10n_util.h"
21 #include "chrome/common/extensions/extension_manifest_constants.h" 22 #include "chrome/common/extensions/extension_manifest_constants.h"
22 #include "chrome/common/url_constants.h" 23 #include "chrome/common/url_constants.h"
23 #include "chrome/common/zip.h" 24 #include "chrome/common/zip.h"
24 #include "content/public/common/common_param_traits.h" 25 #include "content/public/common/common_param_traits.h"
25 #include "grit/generated_resources.h" 26 #include "grit/generated_resources.h"
26 #include "ipc/ipc_message_utils.h" 27 #include "ipc/ipc_message_utils.h"
27 #include "net/base/file_stream.h" 28 #include "net/base/file_stream.h"
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 // Decode any images that the browser needs to display. 196 // Decode any images that the browser needs to display.
196 std::set<FilePath> image_paths = extension->GetBrowserImages(); 197 std::set<FilePath> image_paths = extension->GetBrowserImages();
197 for (std::set<FilePath>::iterator it = image_paths.begin(); 198 for (std::set<FilePath>::iterator it = image_paths.begin();
198 it != image_paths.end(); ++it) { 199 it != image_paths.end(); ++it) {
199 if (!AddDecodedImage(*it)) 200 if (!AddDecodedImage(*it))
200 return false; // Error was already reported. 201 return false; // Error was already reported.
201 } 202 }
202 203
203 // Parse all message catalogs (if any). 204 // Parse all message catalogs (if any).
204 parsed_catalogs_.reset(new DictionaryValue); 205 parsed_catalogs_.reset(new DictionaryValue);
205 if (!extension->default_locale().empty()) { 206 if (!LocaleInfo::GetDefaultLocale(extension).empty()) {
206 if (!ReadAllMessageCatalogs(extension->default_locale())) 207 if (!ReadAllMessageCatalogs(LocaleInfo::GetDefaultLocale(extension)))
207 return false; // Error was already reported. 208 return false; // Error was already reported.
208 } 209 }
209 210
210 return true; 211 return true;
211 } 212 }
212 213
213 bool Unpacker::DumpImagesToFile() { 214 bool Unpacker::DumpImagesToFile() {
214 IPC::Message pickle; // We use a Message so we can use WriteParam. 215 IPC::Message pickle; // We use a Message so we can use WriteParam.
215 IPC::WriteParam(&pickle, decoded_images_); 216 IPC::WriteParam(&pickle, decoded_images_);
216 217
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 331
331 void Unpacker::SetError(const std::string &error) { 332 void Unpacker::SetError(const std::string &error) {
332 SetUTF16Error(UTF8ToUTF16(error)); 333 SetUTF16Error(UTF8ToUTF16(error));
333 } 334 }
334 335
335 void Unpacker::SetUTF16Error(const string16 &error) { 336 void Unpacker::SetUTF16Error(const string16 &error) {
336 error_message_ = error; 337 error_message_ = error;
337 } 338 }
338 339
339 } // namespace extensions 340 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698