chrome/common/extensions/manifest_tests/extension_manifests_default_locale_unittest.cc - Issue 12025010: Move default_locale out of Extension class

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_default_locale_unittest.cc

Issue 12025010: Move default_locale out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/extension_file_util_unittest.cc ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_default_extent_path_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_default_unittest.cc » ('j') | chrome/common/extensions/unpacker_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
	Devlin 2013/01/18 21:08:46 This file should be with the handler. To keep with This file should be with the handler. To keep with how we've been naming them, this one should be c/c/e/api/i18n/default_locale_manifest_unittest.cc Joe Thomas 2013/01/18 22:16:57 Done. Show quoted text On 2013/01/18 21:08:46, D Cronin wrote: > This file should be with the handler. To keep with how we've been naming them, > this one should be c/c/e/api/i18n/default_locale_manifest_unittest.cc Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/common/extensions/api/i18n/default_locale_handler.h"

	6 #include "chrome/common/extensions/extension_manifest_constants.h"

	7 #include "chrome/common/extensions/manifest_handler.h"

	8 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

	9 #include "testing/gtest/include/gtest/gtest.h"

	10

	11 class DefaultLocaleManifestTest : public ExtensionManifestTest {

	12 virtual void SetUp() OVERRIDE {

	13 ExtensionManifestTest::SetUp();

	14 extensions::ManifestHandler::Register(keys::kDefaultLocale,
	Devlin 2013/01/18 21:08:46 This whole file should probably be in the extensio This whole file should probably be in the extensions namespace. Joe Thomas 2013/01/18 22:16:57 Done. Show quoted text On 2013/01/18 21:08:46, D Cronin wrote: > This whole file should probably be in the extensions namespace. Done.
	15 new extensions::DefaultLocaleHandler);

	16 }

	17 };

	18

	19 TEST_F(DefaultLocaleManifestTest, DefaultLocale) {

	20 LoadAndExpectError("default_locale_invalid.json",

	21 errors::kInvalidDefaultLocale);

	22

	23 scoped_refptr<extensions::Extension> extension(

	24 LoadAndExpectSuccess("default_locale_valid.json"));

	25 EXPECT_EQ("de-AT", extensions::LocaleInfo::GetDefaultLocale(extension));

	26 }

OLD	NEW