Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/devtools/front_end/emulated_devices/module.json

Issue 1202493002: [DevTools] Refactor emulated devices modes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/common/Geometry.js ('k') | Source/devtools/front_end/emulation/DevicesSettingsTab.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/emulated_devices/module.json
diff --git a/Source/devtools/front_end/emulated_devices/module.json b/Source/devtools/front_end/emulated_devices/module.json
index a0f0acbb90ad7d8d44f405a3242af833ffef0066..959a2413432bb78895d5572fe71921cb724d264d 100644
--- a/Source/devtools/front_end/emulated_devices/module.json
+++ b/Source/devtools/front_end/emulated_devices/module.json
@@ -4,7 +4,6 @@
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Apple iPhone 4",
"screen": {
"horizontal": {
@@ -22,14 +21,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_2_1 like Mac OS X; en-us) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8C148 Safari/6533.18.5",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Apple iPhone 5",
"screen": {
"horizontal": {
@@ -47,14 +57,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (iPhone; CPU iPhone OS 7_0 like Mac OS X; en-us) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Apple iPhone 6",
"screen": {
"horizontal": {
@@ -72,14 +93,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/600.1.3 (KHTML, like Gecko) Version/8.0 Mobile/12A4345d Safari/600.1.4",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Apple iPhone 6 Plus",
"screen": {
"horizontal": {
@@ -97,14 +129,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/600.1.3 (KHTML, like Gecko) Version/8.0 Mobile/12A4345d Safari/600.1.4",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "BlackBerry Z30",
"screen": {
"horizontal": {
@@ -122,14 +165,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (BB10; Touch) AppleWebKit/537.10+ (KHTML, like Gecko) Version/10.0.9.2372 Mobile Safari/537.10+",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Google Nexus 4",
"screen": {
"horizontal": {
@@ -147,7 +201,19 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; Android 4.4.2; Nexus 4 Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.122 Mobile Safari/537.36",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
@@ -176,62 +242,32 @@
{
"title": "default",
"orientation": "vertical",
- "page-rect": {
- "left": 0,
- "top": 25,
- "width": 360,
- "height": 567
- }
+ "insets": { "left": 0, "top": 25, "right": 0, "bottom": 48 }
},
{
"title": "navigation bar",
"orientation": "vertical",
- "page-rect": {
- "left": 0,
- "top": 80,
- "width": 360,
- "height": 512
- }
+ "insets": { "left": 0, "top": 80, "right": 0, "bottom": 48}
},
{
"title": "keyboard",
"orientation": "vertical",
- "page-rect": {
- "left": 0,
- "top": 80,
- "width": 360,
- "height": 248
- }
+ "insets": { "left": 0, "top": 80, "right": 0, "bottom": 312 }
},
{
"title": "default",
"orientation": "horizontal",
- "page-rect": {
- "left": 0,
- "top": 25,
- "width": 598,
- "height": 335
- }
+ "insets": { "left": 0, "top": 25, "right": 42, "bottom": 0 }
},
{
"title": "navigation bar",
"orientation": "horizontal",
- "page-rect": {
- "left": 0,
- "top": 80,
- "width": 598,
- "height": 280
- }
+ "insets": { "left": 0, "top": 80, "right": 42, "bottom": 0 }
},
{
"title": "keyboard",
"orientation": "horizontal",
- "page-rect": {
- "left": 0,
- "top": 80,
- "width": 598,
- "height": 78
- }
+ "insets": { "left": 0, "top": 80, "right": 42, "bottom": 202 }
}
]
}
@@ -240,7 +276,6 @@
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Google Nexus 6",
"screen": {
"horizontal": {
@@ -258,14 +293,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; Android 5.1.1; Nexus 6 Build/LYZ28E) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/44.0.2403.20 Mobile Safari/537.36",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "LG Optimus L70",
"screen": {
"horizontal": {
@@ -283,14 +329,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; U; Android 4.4.2; en-us; LGMS323 Build/KOT49I.MS32310c) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/30.0.1599.103 Mobile Safari/537.36",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Nokia N9",
"screen": {
"horizontal": {
@@ -308,14 +365,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (MeeGo; NokiaN9) AppleWebKit/534.13 (KHTML, like Gecko) NokiaBrowser/8.5.0 Mobile Safari/534.13",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Nokia Lumia 520",
"screen": {
"horizontal": {
@@ -333,14 +401,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; NOKIA; Lumia 520)",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Samsung Galaxy S III",
"screen": {
"horizontal": {
@@ -358,14 +437,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; U; Android 4.0; en-us; GT-I9300 Build/IMM76D) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Samsung Galaxy S4",
"screen": {
"horizontal": {
@@ -383,14 +473,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; Android 4.2.2; GT-I9505 Build/JDQ39) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.59 Mobile Safari/537.36",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Amazon Kindle Fire HDX",
"screen": {
"horizontal": {
@@ -408,14 +509,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; U; en-us; KFAPWI Build/JDQ39) AppleWebKit/535.19 (KHTML, like Gecko) Silk/3.13 Safari/535.19 Silk-Accelerated=true",
- "type": "tablet"
+ "type": "tablet",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Apple iPad Mini",
"screen": {
"horizontal": {
@@ -433,14 +545,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (iPad; CPU OS 7_0_4 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11B554a Safari/9537.53",
- "type": "tablet"
+ "type": "tablet",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Apple iPad",
"screen": {
"horizontal": {
@@ -458,14 +581,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (iPad; CPU OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53",
- "type": "tablet"
+ "type": "tablet",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "BlackBerry PlayBook",
"screen": {
"horizontal": {
@@ -483,14 +617,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (PlayBook; U; RIM Tablet OS 2.1.0; en-US) AppleWebKit/536.2+ (KHTML like Gecko) Version/7.2.1.0 Safari/536.2+",
- "type": "tablet"
+ "type": "tablet",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Google Nexus 10",
"screen": {
"horizontal": {
@@ -508,14 +653,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; Android 4.3; Nexus 10 Build/JSS15Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2307.2 Safari/537.36",
- "type": "tablet"
+ "type": "tablet",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Google Nexus 7",
"screen": {
"horizontal": {
@@ -533,14 +689,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; Android 4.3; Nexus 7 Build/JSS15Q) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2307.2 Safari/537.36",
- "type": "tablet"
+ "type": "tablet",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Samsung Galaxy Note 3",
"screen": {
"horizontal": {
@@ -558,14 +725,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; U; Android 4.3; en-us; SM-N900T Build/JSS15J) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Samsung Galaxy Note II",
"screen": {
"horizontal": {
@@ -583,14 +761,25 @@
"mobile"
],
"user-agent": "Mozilla/5.0 (Linux; U; Android 4.1; en-us; GT-N7100 Build/JRO03C) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30",
- "type": "phone"
+ "type": "phone",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "vertical",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ },
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Laptop with touch",
"screen": {
"horizontal": {
@@ -607,14 +796,20 @@
"touch"
],
"user-agent": "",
- "type": "notebook"
+ "type": "notebook",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Laptop with HiDPI screen",
"screen": {
"horizontal": {
@@ -629,14 +824,20 @@
},
"capabilities": [],
"user-agent": "",
- "type": "notebook"
+ "type": "notebook",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
},
{
"type": "emulated-device",
"device": {
"show-by-default": true,
- "modes": [],
"title": "Laptop with MDPI screen",
"screen": {
"horizontal": {
@@ -651,7 +852,14 @@
},
"capabilities": [],
"user-agent": "",
- "type": "notebook"
+ "type": "notebook",
+ "modes": [
+ {
+ "title": "default",
+ "orientation": "horizontal",
+ "insets": { "left": 0, "top": 0, "right": 0, "bottom": 0 }
+ }
+ ]
}
}
],
« no previous file with comments | « Source/devtools/front_end/common/Geometry.js ('k') | Source/devtools/front_end/emulation/DevicesSettingsTab.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698