Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(123)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1202493002: [DevTools] Refactor emulated devices modes. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Refactor emulated devices modes. BUG=393493 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -137 lines) Patch
M Source/devtools/front_end/common/Geometry.js View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/devtools/front_end/emulated_devices/module.json View 26 chunks +290 lines, -82 lines 0 comments Download
M Source/devtools/front_end/emulation/DevicesSettingsTab.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/emulation/EmulatedDevices.js View 11 chunks +31 lines, -47 lines 0 comments Download
M Source/devtools/front_end/emulation/ResponsiveDesignView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
dgozman
Take a look please.
4 years, 10 months ago (2015-06-22 16:09:57 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-22 17:52:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202493002/1
4 years, 10 months ago (2015-06-23 10:23:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60263)
4 years, 10 months ago (2015-06-23 11:36:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202493002/1
4 years, 10 months ago (2015-06-23 11:57:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60282)
4 years, 10 months ago (2015-06-23 13:10:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202493002/1
4 years, 10 months ago (2015-06-23 13:11:12 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 14:31:32 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197650

Powered by Google App Engine
This is Rietveld 408576698