content/renderer/service_worker/service_worker_context_client.h - Issue 1202453002: ServiceWorker: Implement navigate() method in WindowClient (chromium side).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 1202453002: ServiceWorker: Implement navigate() method in WindowClient (chromium side). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | content/renderer/service_worker/service_worker_context_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_context_client.h

diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h

index f78758b87ff2d1334c445a39f0a9c2599f7ebb52..bf3d221f4f122642a58987d4a882801bc6dae035 100644

--- a/content/renderer/service_worker/service_worker_context_client.h

+++ b/content/renderer/service_worker/service_worker_context_client.h

@@ -141,6 +141,9 @@ class ServiceWorkerContextClient

blink::WebMessagePortChannelArray* channels);

virtual void focus(const blink::WebString& uuid,

blink::WebServiceWorkerClientCallbacks*);

+ virtual void navigate(const blink::WebString& uuid,

+ const blink::WebURL&,

+ blink::WebServiceWorkerClientCallbacks*);

virtual void skipWaiting(

blink::WebServiceWorkerSkipWaitingCallbacks* callbacks);

virtual void claim(blink::WebServiceWorkerClientsClaimCallbacks* callbacks);

@@ -191,6 +194,9 @@ class ServiceWorkerContextClient

void OnOpenWindowError(int request_id, const std::string& message);

void OnFocusClientResponse(int request_id,

const ServiceWorkerClientInfo& client);

+ void OnNavigateClientResponse(int request_id,

+ const ServiceWorkerClientInfo& client);

+ void OnNavigateClientError(int request_id, const GURL& url);

void OnDidSkipWaiting(int request_id);

void OnDidClaimClients(int request_id);

void OnClaimClientsError(int request_id,