ServiceWorker: Implement navigate() method in WindowClient (chromium side).

content/browser/service_worker/service_worker_version.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_version.h"
 
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/memory/ref_counted.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 1176 matching lines @@
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_OpenWindow,
                         OnOpenWindow)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_SetCachedMetadata,
                         OnSetCachedMetadata)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_ClearCachedMetadata,
                         OnClearCachedMetadata)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_PostMessageToClient,
                         OnPostMessageToClient)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_FocusClient,
                         OnFocusClient)
+    IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_NavigateClient, OnNavigateClient)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_SkipWaiting,
                         OnSkipWaiting)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_ClaimClients,
                         OnClaimClients)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_Pong, OnPongFromWorker)
     IPC_MESSAGE_HANDLER(ServiceWorkerHostMsg_StashMessagePort,
                         OnStashMessagePort)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
@@ skipping 412 matching lines @@
   if (provider_host->document_url().GetOrigin() != script_url_.GetOrigin()) {
     // The client does not belong to the same origin as this ServiceWorker,
     // possibly due to timing issue or bad message.
     return;
   }
   provider_host->Focus(base::Bind(&ServiceWorkerVersion::OnFocusClientFinished,
                                   weak_factory_.GetWeakPtr(), request_id,
                                   client_uuid));
 }
 
+void ServiceWorkerVersion::OnNavigateClient(int request_id,
+                                            const std::string& client_uuid,
+                                            const GURL& url) {
+  if (!context_)
+    return;
+  TRACE_EVENT2("ServiceWorker", "ServiceWorkerVersion::OnNavigateClient",
+               "Request id", request_id, "Client id", client_uuid);
+  ServiceWorkerProviderHost* provider_host =
+      context_->GetProviderHostByClientID(client_uuid);
+  if (!provider_host) {
+    // The client may already have been closed, just ignore.
+    return;
+  }

[nhiroki, 2015/06/23 10:14:37]

We need to verify that provider_host's active worker is equal to this version as
per the spec:

"If the context object's associated service worker client's active worker is not
the incumbent settings object's global object's service worker, return a promise
rejected with a TypeError."

FYI: I think this should be "provider_host's controller". Commented on the spec
issue
(https://github.com/slightlyoff/ServiceWorker/issues/681#issuecomment-114423686)

[zino, 2015/07/07 15:40:36]

Maybe done but I'm not sure.
Please correct me.

+

[nhiroki, 2015/06/23 10:14:37]

|url| passed from a renderer should be verified before using because a renderer
could be compromised (See ServiceWorkerDispatcherHost::OnRegisterServiceWorker
for how to verify. Maybe we should check "url.is_valid()" and its origin?)

[zino, 2015/07/07 15:40:36]

Done.

+  provider_host->Navigate(
+      url,
+      base::Bind(&ServiceWorkerVersion::OnNavigateClientFinished,
+                 weak_factory_.GetWeakPtr(), request_id, client_uuid, url));
+}
+
 void ServiceWorkerVersion::OnFocusClientFinished(
     int request_id,
     const std::string& client_uuid,
     const ServiceWorkerClientInfo& client) {
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
 
   if (running_status() != RUNNING)
     return;
 
   ServiceWorkerClientInfo client_info(client);
   client_info.client_uuid = client_uuid;
 
   embedded_worker_->SendMessage(ServiceWorkerMsg_FocusClientResponse(
       request_id, client_info));
 }
 
+void ServiceWorkerVersion::OnNavigateClientFinished(
+    int request_id,
+    const std::string& client_uuid,
+    const GURL& url,
+    const ServiceWorkerClientInfo& client) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+  if (running_status() != RUNNING)
+    return;
+
+  ServiceWorkerClientInfo client_info(client);
+  client_info.client_uuid = client_uuid;
+
+  if (url.GetOrigin() != script_url_.GetOrigin()) {
+    client_info = ServiceWorkerClientInfo();
+  }

[nhiroki, 2015/06/23 10:14:37]

nit: you don't have to wrap a single line with {}

[zino, 2015/07/07 15:40:36]

Done.

+  embedded_worker_->SendMessage(
+      ServiceWorkerMsg_NavigateClientResponse(request_id, client_info));
+}
+
 void ServiceWorkerVersion::OnSkipWaiting(int request_id) {
   skip_waiting_ = true;
   if (status_ != INSTALLED)
     return DidSkipWaiting(request_id);
 
   if (!context_)
     return;
   ServiceWorkerRegistration* registration =
       context_->GetLiveRegistration(registration_id_);
   if (!registration)
@@ skipping 395 matching lines @@
         return SERVICE_WORKER_ERROR_ABORT;
       default:
         return SERVICE_WORKER_ERROR_NETWORK;
     }
   }
 
   return default_code;
 }
 
 }  // namespace content