Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1202433002: Change large glyph check back to greater-than threshold. (Closed)

Created:
5 years, 6 months ago by jvanverth1
Modified:
5 years, 6 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change large glyph check back to > threshold. Using >= misses some Chromium test cases that are still being rendered as paths. BUG=chromium:467569 Committed: https://skia.googlesource.com/skia/+/34d7288b19920bfb98a6eb280a906840aac51879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gm/mixedtextblobs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
5 years, 6 months ago (2015-06-22 14:39:38 UTC) #2
joshualitt
On 2015/06/22 14:39:38, jvanverth1 wrote: lgtm
5 years, 6 months ago (2015-06-22 14:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202433002/1
5 years, 6 months ago (2015-06-22 15:02:49 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 15:08:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/34d7288b19920bfb98a6eb280a906840aac51879

Powered by Google App Engine
This is Rietveld 408576698