SP: Optimize calculating cull rects for inline text and ellipsis boxes.

SP: Optimize calculating cull rects for inline text and ellipsis boxes.

This patch avoids creating new layout rect objects and going through extra branches
and function calls in the common case that we are painting regular LTR text.
This showed up as a significant portion of total record time on a Reddit comment page.

BUG=503705
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197700

[chrishtr, 2015-06-24 00:13:11]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2015-06-24 00:16:16]

LGTM

[pdr., 2015-06-24 00:16:25]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-06-24 00:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1202413003/1

[wkorman, 2015-06-24 00:45:53]

wkorman@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2015-06-24 00:45:54]

We still have another variant doing it the old way, may be worth changing
separately so they're consistent.

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

https://codereview.chromium.org/1202413003/diff/1/Source/core/layout/line/Inl...
File Source/core/layout/line/InlineBox.cpp (right):

https://codereview.chromium.org/1202413003/diff/1/Source/core/layout/line/Inl...
Source/core/layout/line/InlineBox.cpp:353: return;
don't need return

[chrishtr, 2015-06-24 01:46:43]

On 2015/06/24 at 00:45:54, wkorman wrote:
> We still have another variant doing it the old way, may be worth changing
separately so they're consistent.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
>
https://codereview.chromium.org/1202413003/diff/1/Source/core/layout/line/Inl...
> File Source/core/layout/line/InlineBox.cpp (right):
> 
>
https://codereview.chromium.org/1202413003/diff/1/Source/core/layout/line/Inl...
> Source/core/layout/line/InlineBox.cpp:353: return;
> don't need return

I'll fix this and the other comment in a followup.

[commit-bot: I haz the power, 2015-06-24 02:55:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 02:55:40]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68004)

[chrishtr, 2015-06-24 03:29:55]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-24 03:30:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1202413003/1

[commit-bot: I haz the power, 2015-06-24 04:25:21]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197700