Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1202323002: Port sky_shell to Linux for testing (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Port sky_shell to Linux for testing This CL makes it possible to build sky_shell on Linux. It doesn't do much, but it doesn't crash on startup. The goal is to evetually be able to test sky_shell on the bots and to be able to run the test_sky on Mac. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7f9aa916cdc889322808e016a6d08384737eae43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -6 lines) Patch
M sky/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/shell/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download
M sky/shell/gpu/rasterizer.h View 1 chunk +1 line, -1 line 0 comments Download
A sky/shell/linux/main.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A sky/shell/linux/platform_service_provider_linux.cc View 1 chunk +22 lines, -0 lines 0 comments Download
A + sky/shell/linux/platform_view_linux.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/shell/platform_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/shell/platform_view.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/shell/service_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
A sky/shell/service_provider.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M sky/shell/ui/engine.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sky/shell/ui/engine.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/shell/ui/internals.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-23 21:09:45 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-23 21:12:13 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-23 21:17:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f9aa916cdc889322808e016a6d08384737eae43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698