Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1202283004: Factor DartLibraryProvider out of DartLoader (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Factor DartLibraryProvider out of DartLoader This CL factors the network interactions out of DartLoader into a DartLibraryProvider interface, paving the way for other library providers (e.g., offline). As part of this CL, I've renamed DartLoader to DartLibraryLoader and moved the class into tonic, where it can't have any direct network dependencies. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5860efcd4587a3e01f5dd8910d4b635ab9358721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -746 lines) Patch
M sky/engine/core/core.gni View 1 chunk +2 lines, -6 lines 0 comments Download
M sky/engine/core/script/dart_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 7 chunks +35 lines, -9 lines 0 comments Download
D sky/engine/core/script/dart_dependency_catcher.h View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/script/dart_dependency_catcher.cc View 1 chunk +0 lines, -23 lines 0 comments Download
A sky/engine/core/script/dart_library_provider_network.h View 1 chunk +44 lines, -0 lines 0 comments Download
A sky/engine/core/script/dart_library_provider_network.cc View 1 chunk +84 lines, -0 lines 0 comments Download
D sky/engine/core/script/dart_loader.h View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/engine/core/script/dart_loader.cc View 1 chunk +0 lines, -308 lines 0 comments Download
D sky/engine/core/script/dart_snapshot_loader.h View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/engine/core/script/dart_snapshot_loader.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/tonic/BUILD.gn View 3 chunks +9 lines, -0 lines 0 comments Download
A + sky/engine/tonic/dart_dependency_catcher.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + sky/engine/tonic/dart_dependency_catcher.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A + sky/engine/tonic/dart_library_loader.h View 4 chunks +23 lines, -15 lines 0 comments Download
A + sky/engine/tonic/dart_library_loader.cc View 9 chunks +69 lines, -97 lines 0 comments Download
A sky/engine/tonic/dart_library_provider.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + sky/engine/tonic/dart_library_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/engine/tonic/dart_snapshot_loader.h View 2 chunks +6 lines, -17 lines 0 comments Download
A + sky/engine/tonic/dart_snapshot_loader.cc View 2 chunks +4 lines, -18 lines 0 comments Download
M sky/engine/tonic/dart_state.h View 3 chunks +5 lines, -2 lines 0 comments Download
M sky/engine/tonic/dart_state.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-24 08:03:03 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-24 16:12:00 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-06-24 16:32:28 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5860efcd4587a3e01f5dd8910d4b635ab9358721 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698