Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(136)

Issue 1202263005: Adding Internals.numberOfLiveAXObjects to test for leaking AXObjects (Closed)

Created:
4 years, 10 months ago by keishi
Modified:
4 years, 10 months ago
Reviewers:
haraken, dmazzoni
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding Internals.numberOfLiveAXObjects to test for leaking AXObjects BUG=502782 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197796

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -12 lines) Patch
M LayoutTests/accessibility/AccessibilityScrollbar-leak.html View 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/accessibility/AccessibilityScrollbar-leak-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/resources/leak-check.js View 1 chunk +4 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A + Source/modules/accessibility/testing/InternalsAccessibility.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + Source/modules/accessibility/testing/InternalsAccessibility.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
A + Source/modules/accessibility/testing/InternalsAccessibility.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/modules.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
keishi
4 years, 10 months ago (2015-06-24 11:38:49 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-24 11:50:17 UTC) #3
dmazzoni
I'm assuming this will be rebased on top of two other changes that land first, ...
4 years, 10 months ago (2015-06-24 14:22:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202263005/20001
4 years, 10 months ago (2015-06-25 01:11:37 UTC) #7
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2015-06-25 01:14:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202263005/40001
4 years, 10 months ago (2015-06-25 03:09:24 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 04:32:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197796

Powered by Google App Engine
This is Rietveld 408576698