Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1202263004: Use EditingTestBase for PositionTest (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use EditingTestBase for PositionTest This CL changes PositionTest to inherit EditingTestBase to reduce duplicated code. This CL also changes EditingTestBase::setShadowContent to recalc distributions which is required by PositionTest. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197730

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -50 lines) Patch
M Source/core/dom/PositionTest.cpp View 1 chunk +2 lines, -49 lines 0 comments Download
M Source/core/editing/EditingTestBase.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-24 09:23:48 UTC) #2
hajimehoshi
+tkent for core/dom
4 years, 10 months ago (2015-06-24 09:24:16 UTC) #4
tkent
lgtm https://codereview.chromium.org/1202263004/diff/1/Source/core/editing/EditingTestBase.cpp File Source/core/editing/EditingTestBase.cpp (right): https://codereview.chromium.org/1202263004/diff/1/Source/core/editing/EditingTestBase.cpp#newcode50 Source/core/editing/EditingTestBase.cpp:50: return shadowRoot; shadowRoot -> shadowRoot.release()
4 years, 10 months ago (2015-06-24 09:27:41 UTC) #5
yosin_UTC9
lgtm In description, s/redundant/duplicated/ ?
4 years, 10 months ago (2015-06-24 09:28:20 UTC) #6
hajimehoshi
Thank you! https://codereview.chromium.org/1202263004/diff/1/Source/core/editing/EditingTestBase.cpp File Source/core/editing/EditingTestBase.cpp (right): https://codereview.chromium.org/1202263004/diff/1/Source/core/editing/EditingTestBase.cpp#newcode50 Source/core/editing/EditingTestBase.cpp:50: return shadowRoot; On 2015/06/24 09:27:41, tkent wrote: ...
4 years, 10 months ago (2015-06-24 09:52:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202263004/20001
4 years, 10 months ago (2015-06-24 09:53:08 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 10:57:52 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197730

Powered by Google App Engine
This is Rietveld 408576698