Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1202233002: DevTools: remove parsedstylesheet struct, inline it into inspectorstylesheet. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove parsedstylesheet struct, inline it into inspectorstylesheet. BUG=178410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197676

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -170 lines) Patch
M Source/core/inspector/InspectorStyleSheet.h View 4 chunks +3 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 20 chunks +72 lines, -163 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
pfeldman
4 years, 10 months ago (2015-06-23 15:51:50 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/1202233002/diff/1/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/1202233002/diff/1/Source/core/inspector/InspectorStyleSheet.cpp#newcode1033 Source/core/inspector/InspectorStyleSheet.cpp:1033: String sheetText = m_text; you can avoid this ...
4 years, 10 months ago (2015-06-23 17:58:44 UTC) #3
pfeldman
It is refcounted!
4 years, 10 months ago (2015-06-23 19:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202233002/1
4 years, 10 months ago (2015-06-23 19:46:45 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 21:21:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197676

Powered by Google App Engine
This is Rietveld 408576698