Separate local and remote sync invalidations

chrome/browser/sync/glue/sync_backend_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/sync_backend_host.h"
 
 #include <cstddef>
 
 #include "base/location.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/sync/glue/device_info.h"
 #include "chrome/browser/sync/glue/synced_device_tracker.h"
 #include "chrome/browser/sync/invalidations/invalidator_storage.h"
 #include "chrome/browser/sync/sync_prefs.h"
+#include "chrome/common/chrome_notification_types.h"
 #include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/notification_service.h"
 #include "content/public/test/test_browser_thread.h"
 #include "google/cacheinvalidation/include/types.h"
 #include "googleurl/src/gurl.h"
 #include "net/url_request/test_url_fetcher_factory.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/engine/model_safe_worker.h"
 #include "sync/internal_api/public/sync_manager_factory.h"
 #include "sync/internal_api/public/test/fake_sync_manager.h"
 #include "sync/internal_api/public/util/experiments.h"
 #include "sync/notifier/invalidator_state.h"
@@ skipping 193 matching lines @@
         config_state_map,
         base::Bind(&SyncBackendHostTest::DownloadReady,
                    base::Unretained(this)),
         base::Bind(&SyncBackendHostTest::OnDownloadRetry,
                    base::Unretained(this)));
     ui_loop_.PostDelayedTask(FROM_HERE,
         ui_loop_.QuitClosure(), TestTimeouts::action_timeout());
     ui_loop_.Run();
   }
 
+  void IssueRefreshRequest(syncer::ModelTypeSet types) {
+    DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+    syncer::ModelTypeInvalidationMap invalidation_map(
+        ModelTypeSetToInvalidationMap(types, std::string()));
+
+    content::NotificationService::current()->Notify(
+        chrome::NOTIFICATION_SYNC_REFRESH_LOCAL,
+        content::Source<Profile>(profile_.get()),
+        content::Details<syncer::ModelTypeInvalidationMap>(
+            &invalidation_map));
+  }
+
  protected:
   void DownloadReady(syncer::ModelTypeSet types) {
     MessageLoop::current()->Quit();
   }
 
   void OnDownloadRetry() {
     NOTIMPLEMENTED();
   }
 
   MessageLoop ui_loop_;
@@ skipping 441 matching lines @@
 // should detect this condition and fail to initialize the backend.
 //
 // The failure is "silent" in the sense that the GetUpdates request appears to
 // be successful, but it returned no results.  This means that the usual
 // download retry logic will not be invoked.
 TEST_F(SyncBackendHostTest, SilentlyFailToDownloadControlTypes) {
   fake_manager_factory_.set_configure_fail_types(syncer::ModelTypeSet::All());
   InitializeBackend(false);
 }
 
+// Test that local refresh requests are delivered to sync.
+TEST_F(SyncBackendHostTest, ForwardLocalRefreshRequest) {
+  InitializeBackend(true);
+
+  syncer::ModelTypeSet set1 = syncer::ModelTypeSet::All();
+  IssueRefreshRequest(set1);
+  fake_manager_->WaitForSyncThread();
+  EXPECT_TRUE(set1.Equals(fake_manager_->GetLastRefreshRequestTypes()));
+
+  syncer::ModelTypeSet set2 = syncer::ModelTypeSet(syncer::SESSIONS);
+  IssueRefreshRequest(set2);
+  fake_manager_->WaitForSyncThread();
+  EXPECT_TRUE(set2.Equals(fake_manager_->GetLastRefreshRequestTypes()));
+}
+
+// Test that local invalidations issued before sync is initialized are ignored.
+TEST_F(SyncBackendHostTest, AttemptForwardLocalRefreshRequestEarly) {
+  syncer::ModelTypeSet set1 = syncer::ModelTypeSet::All();
+  IssueRefreshRequest(set1);
+
+  InitializeBackend(true);
+
+  fake_manager_->WaitForSyncThread();
+  EXPECT_FALSE(set1.Equals(fake_manager_->GetLastRefreshRequestTypes()));
+}
+
+// Test that local invalidations issued while sync is shutting down are ignored.
+TEST_F(SyncBackendHostTest, AttemptForwardLocalRefreshRequestLate) {
+  InitializeBackend(true);
+
+  backend_->StopSyncingForShutdown();
+
+  syncer::ModelTypeSet types = syncer::ModelTypeSet::All();
+  IssueRefreshRequest(types);
+  fake_manager_->WaitForSyncThread();
+  EXPECT_FALSE(types.Equals(fake_manager_->GetLastRefreshRequestTypes()));
+
+  backend_->Shutdown(false);
+  backend_.reset();
+}
+
 }  // namespace
 
 }  // namespace browser_sync