Fixing activation states from the new launcher. Also adding a whole bunch of unit tests for the new…

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 624 matching lines @@
 
 void BrowserView::FlashFrame(bool flash) {
   frame_->FlashFrame(flash);
 }
 
 bool BrowserView::IsAlwaysOnTop() const {
   return false;
 }
 
 gfx::NativeWindow BrowserView::GetNativeWindow() {
+  // While the browser destruction is going on, the widget can already be gone,
+  // but utility functions like FindBrowserWithWindow will come here and crash.
+  // We short circuit therefore.
+  if (!GetWidget())
+    return NULL;
   return GetWidget()->GetTopLevelWidget()->GetNativeWindow();
 }
 
 BrowserWindowTesting* BrowserView::GetBrowserWindowTesting() {
   return this;
 }
 
 StatusBubble* BrowserView::GetStatusBubble() {
   return status_bubble_.get();
 }
@@ skipping 1948 matching lines @@
 
   Browser* modal_browser =
       chrome::FindBrowserWithWebContents(active_dialog->web_contents());
   if (modal_browser && (browser_ != modal_browser)) {
     modal_browser->window()->FlashFrame(true);
     modal_browser->window()->Activate();
   }
 
   AppModalDialogQueue::GetInstance()->ActivateModalDialog();
 }