Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1202193002: Make setSinkId try to set the sink even if the given new sinkId equals the current sinkId. (Closed)

Created:
4 years, 10 months ago by Guido Urdaneta
Modified:
4 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make setSinkId try to set the sink even if the given new sinkId equals the current sinkId. Given that we currently do not support automatically resetting the sink when the source of an HTMLMediaElement changes, this patch helps avoid the following problematic scenario: elem.setSinkId(mySink); elem.src = newSrc; // audio will not necessarily be rendered on mySink elem.setSinkId(mySink); //does nothing because mySink equals the sinkId for the element. BUG=438023 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Guido Urdaneta
Hi, please review.
4 years, 10 months ago (2015-06-23 12:07:55 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 10 months ago (2015-06-23 20:21:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202193002/1
4 years, 10 months ago (2015-06-23 20:22:17 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 22:06:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197677

Powered by Google App Engine
This is Rietveld 408576698