Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1202173002: Remove --pretenuring-call-new (Closed)

Created:
5 years, 6 months ago by mvstanton
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --pretenure-call-new There isn't a plan to turn it on soon, so we'll take it out in favor of cleaner code. BUG= Committed: https://crrev.com/b5588f48fd0b4e3ee43be1fe6c19d7ddd8b8b5f1 Cr-Commit-Position: refs/heads/master@{#30767}

Patch Set 1 #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE. #

Patch Set 4 : Fix 64 bit release build break. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -928 lines) Patch
M src/arm/builtins-arm.cc View 1 2 8 chunks +8 lines, -63 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 chunks +34 lines, -46 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 6 chunks +13 lines, -63 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 chunks +34 lines, -47 lines 0 comments Download
M src/ast.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M src/hydrogen.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 9 chunks +7 lines, -57 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 chunks +36 lines, -49 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 8 chunks +9 lines, -66 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 chunks +33 lines, -46 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 8 chunks +9 lines, -66 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 chunks +33 lines, -45 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M src/type-info.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M src/typing.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 8 chunks +7 lines, -57 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 chunks +31 lines, -44 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +0 lines, -100 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
mvstanton
Hi Hannes, here is the CL, thx for the look! --Michael
5 years, 6 months ago (2015-06-23 10:36:56 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-16 07:28:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/20001
5 years, 3 months ago (2015-09-16 07:28:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/8021) v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 07:29:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/40001
5 years, 3 months ago (2015-09-16 14:31:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9756) v8_presubmit on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-09-16 14:33:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/60001
5 years, 3 months ago (2015-09-16 14:57:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5841)
5 years, 3 months ago (2015-09-16 15:04:28 UTC) #17
Jakob Kummerow
src/full-codegen/* LGTM.
5 years, 3 months ago (2015-09-16 15:10:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202173002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1202173002/60001
5 years, 3 months ago (2015-09-16 15:11:04 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-16 15:12:31 UTC) #22
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 15:12:52 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b5588f48fd0b4e3ee43be1fe6c19d7ddd8b8b5f1
Cr-Commit-Position: refs/heads/master@{#30767}

Powered by Google App Engine
This is Rietveld 408576698