Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1202153003: Removing unused functions from FileChooser class (Closed)

Created:
5 years, 6 months ago by shiva.jm
Modified:
5 years, 6 months ago
Reviewers:
pdr., Mike West
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing unused function from FileChooser class This patch removes the following unused function: FileChooser::chooseFiles() BUG=439559 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M Source/platform/FileChooser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/FileChooser.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
shiva.jm
pls have a look.
5 years, 6 months ago (2015-06-23 09:08:09 UTC) #2
Mike West
I think this is required for Mac, isn't it? LGTM if everything (including chromium/chromiumos bots) ...
5 years, 6 months ago (2015-06-23 09:17:02 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202153003/1
5 years, 6 months ago (2015-06-23 09:18:28 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-23 10:19:00 UTC) #7
shiva.jm
On 2015/06/23 09:17:02, Mike West wrote: > I think this is required for Mac, isn't ...
5 years, 6 months ago (2015-06-23 11:40:14 UTC) #8
Mike West
On 2015/06/23 at 11:40:14, shiva.jm wrote: > On 2015/06/23 09:17:02, Mike West wrote: > > ...
5 years, 6 months ago (2015-06-23 11:41:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202153003/1
5 years, 6 months ago (2015-06-23 11:56:49 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 12:00:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197642

Powered by Google App Engine
This is Rietveld 408576698