Adding tests for the prompt() method on the beforeinstallprompt event

Adding tests for the prompt() method on the beforeinstallprompt event

The prompt() method may only be called a single time following a
preventDefault() on the beforeinstallprompt event. Other cases result in
the method returning a rejected promise. These tests verify that prompt()
correctly allows the event to continue, whilst correctly returning a
rejected promise in other circumstances.

BUG=490545
R=mlamouri@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197847

[mlamouri (slow - plz ping), 2015-06-24 13:56:51]

https://codereview.chromium.org/1202043002/diff/1/LayoutTests/app_banner/app-...
File LayoutTests/app_banner/app-banner-event-prompt.html (right):

https://codereview.chromium.org/1202043002/diff/1/LayoutTests/app_banner/app-...
LayoutTests/app_banner/app-banner-event-prompt.html:68:
assert_equals(result.outcome, test_case.outcome, 'Outcome');
What about:

e.userChoice.then(t.step_func(function(result) {
  assert_equals(...);
  assert-equals(...);
}).then(t.step_func(verify_prompt_reject(e, t)
  .then(t.step_func(function() {
  prompt_test(index + 1);
  t.done();
}), t.unreached_func("...."));

[dominickn, 2015-06-24 23:09:13]

https://codereview.chromium.org/1202043002/diff/1/LayoutTests/app_banner/app-...
File LayoutTests/app_banner/app-banner-event-prompt.html (right):

https://codereview.chromium.org/1202043002/diff/1/LayoutTests/app_banner/app-...
LayoutTests/app_banner/app-banner-event-prompt.html:68:
assert_equals(result.outcome, test_case.outcome, 'Outcome');
On 2015/06/24 13:56:51, Mounir Lamouri wrote:
> What about:
> 
> e.userChoice.then(t.step_func(function(result) {
>   assert_equals(...);
>   assert-equals(...);
> }).then(t.step_func(verify_prompt_reject(e, t)
>   .then(t.step_func(function() {
>   prompt_test(index + 1);
>   t.done();
> }), t.unreached_func("...."));

Done. Also added tests for prompt() calls outside the handler, and factored this
out into a function.

[mlamouri (slow - plz ping), 2015-06-25 10:17:36]

Your tests look good. Thanks! :)

lgtm with the changes suggested below.

https://codereview.chromium.org/1202043002/diff/20001/LayoutTests/app_banner/...
File LayoutTests/app_banner/app-banner-event-prompt.html (right):

https://codereview.chromium.org/1202043002/diff/20001/LayoutTests/app_banner/...
LayoutTests/app_banner/app-banner-event-prompt.html:85: if (test_case.cancel) {
You are assuming test_case.cancel will be true if test_case.late is. Maybe you
could do some small changes to have the code more flexible?

Something like:
if (test_case.late)
  return;

then you continue business as usual.

https://codereview.chromium.org/1202043002/diff/20001/LayoutTests/app_banner/...
LayoutTests/app_banner/app-banner-event-prompt.html:111:
event.prompt().then(function() { }, t.unreached_func("prompt() promise should
resolve."));
... and here, given that preventDefault() wasn't called, you do:
if (test_case.late) {
  if (test_case.cancel)
    event.preventDefault();
  event.prompt() [...]
  [...]
}

[dominickn, 2015-06-25 17:30:21]

Also added an additional test for rejecting prompt() outside the handler without
preventDefault(). Thanks for the suggested changes. :)

https://codereview.chromium.org/1202043002/diff/20001/LayoutTests/app_banner/...
File LayoutTests/app_banner/app-banner-event-prompt.html (right):

https://codereview.chromium.org/1202043002/diff/20001/LayoutTests/app_banner/...
LayoutTests/app_banner/app-banner-event-prompt.html:85: if (test_case.cancel) {
On 2015/06/25 10:17:36, Mounir Lamouri wrote:
> You are assuming test_case.cancel will be true if test_case.late is. Maybe you
> could do some small changes to have the code more flexible?
> 
> Something like:
> if (test_case.late)
>   return;
> 
> then you continue business as usual.

Done.

https://codereview.chromium.org/1202043002/diff/20001/LayoutTests/app_banner/...
LayoutTests/app_banner/app-banner-event-prompt.html:111:
event.prompt().then(function() { }, t.unreached_func("prompt() promise should
resolve."));
On 2015/06/25 10:17:36, Mounir Lamouri wrote:
> ... and here, given that preventDefault() wasn't called, you do:
> if (test_case.late) {
>   if (test_case.cancel)
>     event.preventDefault();
>   event.prompt() [...]
>   [...]
> }

Done.

[dominickn, 2015-06-25 18:35:59]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2015-06-25 18:36:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1202043002/#ps40001
(title: "Addressing reviewer comments and adding additional test")

[commit-bot: I haz the power, 2015-06-25 18:36:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1202043002/40001

[commit-bot: I haz the power, 2015-06-25 19:14:38]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197847