Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1202023002: fix spurious init on VisualBench startup (Closed)

Created:
5 years, 6 months ago by joshua.litt
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix spurious init on VisualBench startup BUG=skia: Committed: https://skia.googlesource.com/skia/+/fef3fad272699ecc1363664bfb4c121462761c06

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java View 1 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
joshualitt
ptal
5 years, 6 months ago (2015-06-22 17:18:34 UTC) #2
tomhudson
LGTM modulo nits https://codereview.chromium.org/1202023002/diff/1/platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java File platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java (right): https://codereview.chromium.org/1202023002/diff/1/platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java#newcode28 platform_tools/android/visualbench/src/com/skia/VisualBenchActivity.java:28: // Setup a bunch of window ...
5 years, 6 months ago (2015-06-22 17:21:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1202023002/20001
5 years, 6 months ago (2015-06-22 17:23:10 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 17:44:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fef3fad272699ecc1363664bfb4c121462761c06

Powered by Google App Engine
This is Rietveld 408576698