Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 1201993002: Let GC select the collector when the external memory allocation limit is reached (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let GC select the collector when the external memory allocation limit is reached BUG=none R=hpayer@chromium.org LOG=n Committed: https://crrev.com/93d6216099b60e95bc816bcc913f8f841ee795b6 Cr-Commit-Position: refs/heads/master@{#29235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-06-22 15:21:13 UTC) #1
Hannes Payer (out of office)
On 2015/06/22 15:21:13, jochen wrote: Lgtm
5 years, 6 months ago (2015-06-23 14:59:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201993002/1
5 years, 6 months ago (2015-06-23 15:00:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 15:02:10 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/93d6216099b60e95bc816bcc913f8f841ee795b6 Cr-Commit-Position: refs/heads/master@{#29235}
5 years, 6 months ago (2015-06-23 15:02:31 UTC) #6
jochen (gone - plz use gerrit)
5 years, 5 months ago (2015-06-30 15:14:16 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1215513004/ by jochen@chromium.org.

The reason for reverting is: results in a scavenge storm if scavenge doesn't
free enough memory.

Powered by Google App Engine
This is Rietveld 408576698