Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1201983003: Oilpan: eagerly finalize CSSCrossfadeValue. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: eagerly finalize CSSCrossfadeValue. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197633

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/core/css/CSSCrossfadeValue.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look. There are other ImageResourceClients affected also, but handling them one at ...
5 years, 6 months ago (2015-06-23 06:15:43 UTC) #2
haraken
LGTM (I'm trying to improve pre-finalizers so that we don't need to add these magic ...
5 years, 6 months ago (2015-06-23 06:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201983003/20001
5 years, 6 months ago (2015-06-23 06:44:42 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 07:28:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197633

Powered by Google App Engine
This is Rietveld 408576698