Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/pkg.status

Issue 1201983002: Implement try/finally by inlining the finally code. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Do not translate any more finally blocks after one exits. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | samples/samples.status » ('j') | tests/compiler/dart2js_extra/dart2js_extra.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/pkg.status
diff --git a/pkg/pkg.status b/pkg/pkg.status
index db093f9c26ab09a7ae0cb4d19223edadd5a53fbc..98be371f3e4af4c243ada1fdbbd7a02c250be64d 100644
--- a/pkg/pkg.status
+++ b/pkg/pkg.status
@@ -151,48 +151,48 @@ analyzer/test/*: PubGetError
[ $compiler == dart2js && $cps_ir ]
analysis_server/tool/spec/check_all_test: Crash # Invalid argument(s)
-analyzer/test/cancelable_future_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/enum_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/file_system/memory_file_system_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/file_system/physical_resource_provider_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/file_system/resource_uri_resolver_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/all_the_rest_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/generated/ast_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/compile_time_error_code_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/element_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/incremental_resolver_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/incremental_scanner_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/java_core_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/generated/java_io_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/generated/non_error_resolver_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/parser_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/resolver_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/scanner_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/static_type_warning_code_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/static_warning_code_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/type_system_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/generated/utilities_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/instrumentation/instrumentation_test: Crash # (try {body();}catch ... try/finally
+analyzer/test/cancelable_future_test: Crash # Invalid argument(s)
Kevin Millikin (Google) 2015/06/22 15:36:42 All these "Invalid argument(s)" failures have some
+analyzer/test/enum_test: Crash # Invalid argument(s)
+analyzer/test/file_system/memory_file_system_test: Crash # Invalid argument(s)
+analyzer/test/file_system/physical_resource_provider_test: Crash # Invalid argument(s)
+analyzer/test/file_system/resource_uri_resolver_test: Crash # Invalid argument(s)
+analyzer/test/generated/all_the_rest_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/generated/ast_test: Crash # Invalid argument(s)
+analyzer/test/generated/compile_time_error_code_test: Crash # Invalid argument(s)
+analyzer/test/generated/element_test: Crash # Invalid argument(s)
+analyzer/test/generated/incremental_resolver_test: Crash # Invalid argument(s)
+analyzer/test/generated/incremental_scanner_test: Crash # Invalid argument(s)
+analyzer/test/generated/java_core_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/generated/java_io_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/generated/non_error_resolver_test: Crash # Invalid argument(s)
+analyzer/test/generated/parser_test: Crash # Invalid argument(s)
+analyzer/test/generated/resolver_test: Crash # Invalid argument(s)
+analyzer/test/generated/scanner_test: Crash # Invalid argument(s)
+analyzer/test/generated/static_type_warning_code_test: Crash # Invalid argument(s)
+analyzer/test/generated/static_warning_code_test: Crash # Invalid argument(s)
+analyzer/test/generated/type_system_test: Crash # Invalid argument(s)
+analyzer/test/generated/utilities_test: Crash # Invalid argument(s)
+analyzer/test/instrumentation/instrumentation_test: Crash # (try {body();}catch ... try/catch/finally
analyzer/test/parse_compilation_unit_test: Crash # Invalid argument(s)
-analyzer/test/source/package_map_provider_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/source/package_map_resolver_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/context/cache_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/src/context/context_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/src/task/dart_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/task/dart_work_manager_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/src/task/driver_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/src/task/general_test: Crash # (try {body();}catch ... try/finally
-analyzer/test/src/task/html_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/task/incremental_element_builder_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/task/inputs_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/task/manager_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/task/model_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/util/asserts_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-analyzer/test/src/util/lru_map_test: Crash # (try {test(spec,body);}finally {environment.soloNestingLevel-- ;}): try/finally
-fixnum/test/int_32_test: Crash # (try {body();}catch ... try/finally
-fixnum/test/int_64_test: Crash # (try {body();}catch ... try/finally
+analyzer/test/source/package_map_provider_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/source/package_map_resolver_test: Crash # Invalid argument(s)
+analyzer/test/src/context/cache_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/src/context/context_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/src/task/dart_test: Crash # Invalid argument(s)
+analyzer/test/src/task/dart_work_manager_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/src/task/driver_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/src/task/general_test: Crash # (try {body();}catch ... try/catch/finally
+analyzer/test/src/task/html_test: Crash # Invalid argument(s)
+analyzer/test/src/task/incremental_element_builder_test: Crash # Invalid argument(s)
+analyzer/test/src/task/inputs_test: Crash # Invalid argument(s)
+analyzer/test/src/task/manager_test: Crash # Invalid argument(s)
+analyzer/test/src/task/model_test: Crash # Invalid argument(s)
+analyzer/test/src/util/asserts_test: Crash # Invalid argument(s)
+analyzer/test/src/util/lru_map_test: Crash # Invalid argument(s)
+fixnum/test/int_32_test: Crash # (try {body();}catch ... try/catch/finally
+fixnum/test/int_64_test: Crash # (try {body();}catch ... try/catch/finally
js_ast/test/printer_callback_test: Crash # Issue 23691
microlytics/test/dart_microlytics_test: RuntimeError # Please triage this failure.
typed_data/test/typed_buffers_test/01: Crash # Invalid argument(s)
typed_data/test/typed_buffers_test/none: Crash # Invalid argument(s)
-typed_mock/test/typed_mock_test: Crash # (try {body();}catch ... try/finally
+typed_mock/test/typed_mock_test: Crash # (try {body();}catch ... try/catch/finally
« pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | samples/samples.status » ('j') | tests/compiler/dart2js_extra/dart2js_extra.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698