Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1201983002: Implement try/finally by inlining the finally code. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Run all the finally blocks. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index aebd19dbd5fa85b098d1f1d28049b93dde0091cc..ec74ea7734ef5f020288fb69e6ce35896cb0962f 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -433,9 +433,9 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
}
visitTryStatement(ast.TryStatement node) {
- // Finally blocks are not yet implemented.
- if (node.finallyBlock != null) {
- return giveup(node, 'try/finally');
+ // Try/catch/finally is not yet implemented.
+ if (!node.catchBlocks.isEmpty && node.finallyBlock != null) {
+ return giveup(node, 'try/catch/finally');
}
List<CatchClauseInfo> catchClauseInfos = <CatchClauseInfo>[];
@@ -457,10 +457,13 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
buildCatchBlock: subbuild(catchClause.block)));
}
+ SubbuildFunction buildFinallyBlock =
+ node.finallyBlock == null ? null : subbuild(node.finallyBlock);
irBuilder.buildTry(
tryStatementInfo: tryStatements[node],
buildTryBlock: subbuild(node.tryBlock),
catchClauseInfos: catchClauseInfos,
+ buildFinallyBlock: buildFinallyBlock,
closureClassMap: closureClassMap);
}

Powered by Google App Engine
This is Rietveld 408576698