Tools/Scripts/webkitpy/common/system/user.py - Issue 1201873002: Move LayoutTest Linux distribution detection to PlatformInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/common/system/user.py

Issue 1201873002: Move LayoutTest Linux distribution detection to PlatformInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use ServerRoot without symlink Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Tools/Scripts/webkitpy/common/system/systemhost.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('j') | Tools/Scripts/webkitpy/layout_tests/port/base.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Tools/Scripts/webkitpy/common/system/user.py

diff --git a/Tools/Scripts/webkitpy/common/system/user.py b/Tools/Scripts/webkitpy/common/system/user.py

index 494bf213070de438329822839778b394f5c23809..da02d8555154823517334c4f1f2c2a0fd2f8f12d 100644

--- a/Tools/Scripts/webkitpy/common/system/user.py

+++ b/Tools/Scripts/webkitpy/common/system/user.py

@@ -37,6 +37,7 @@ import sys

import webbrowser

from webkitpy.common.system.executive import Executive

+from webkitpy.common.system.filesystem import FileSystem

from webkitpy.common.system.platforminfo import PlatformInfo

@@ -50,7 +51,7 @@ class User(object):

def __init__(self, platforminfo=None):

# We cannot get the PlatformInfo object from a SystemHost because

# User is part of SystemHost itself.

- self._platforminfo = platforminfo or PlatformInfo(sys, platform, Executive())

+ self._platforminfo = platforminfo or PlatformInfo(sys, platform, FileSystem(), Executive())

# FIXME: These are @classmethods because bugzilla.py doesn't have a Tool object (thus no User instance).

@classmethod