Issue 12018035: google_apis: Remove unused includes of chrome_paths.h from two unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12018035: google_apis: Remove unused includes of chrome_paths.h from two unittests. (Closed)

Created:
7 years, 11 months ago by tfarina

Modified:
7 years, 11 months ago

Reviewers:
satorux1

CC:
chromium-reviews, achuith+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

google_apis: Remove unused includes of chrome_paths.h from two unittests. BUG=146989 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177870

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/google_apis/drive_api_parser_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/google_apis/gdata_wapi_parser_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

satorux1

LGTM. Thanks. My understanding is that TBR should usually be avoided. There is no rush ...

7 years, 11 months ago (2013-01-19 23:07:30 UTC) #2

tfarina

On 2013/01/19 23:07:30, satorux1 wrote: > LGTM. Thanks. > > My understanding is that TBR ...

7 years, 11 months ago (2013-01-19 23:09:08 UTC) #3

satorux1

It's not always safe to submit clean up patches, especially after a release branch is ...

7 years, 11 months ago (2013-01-19 23:19:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12018035/1

7 years, 11 months ago (2013-01-20 00:38:36 UTC) #5

Message was sent while issue was closed.

Change committed as 177870