webkit/fileapi/obfuscated_file_util.cc - Issue 12018017: FileAPI: Split recursive remove into multiple async tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/fileapi/obfuscated_file_util.cc

Issue 12018017: FileAPI: Split recursive remove into multiple async tasks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase + addressed comment #2 Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/fileapi/obfuscated_file_util.cc

diff --git a/webkit/fileapi/obfuscated_file_util.cc b/webkit/fileapi/obfuscated_file_util.cc

index 4e743c689de7d0bb4ac5b216ef5162e42894c000..9bd64bc1cce38997332cb4f80eb78e9c7657f2aa 100644

--- a/webkit/fileapi/obfuscated_file_util.cc

+++ b/webkit/fileapi/obfuscated_file_util.cc

@@ -813,10 +813,8 @@ PlatformFileError ObfuscatedFileUtil::DeleteFile(

error != base::PLATFORM_FILE_OK)

return error;

- if (file_info.is_directory()) {

- NOTREACHED();

- return base::PLATFORM_FILE_ERROR_FAILED;

- }

+ if (file_info.is_directory())

+ return base::PLATFORM_FILE_ERROR_NOT_A_FILE;

int64 growth = -UsageForPath(file_info.name.size()) - platform_file_info.size;

AllocateQuota(context, growth);