Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4682)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 12018007: Refactor BrowserWindow fullscreen and presentation on Mac to be consistent with other platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge TOT Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index 0bf68d3a549fa7fcea0b46f577cbf2840f4d5f89..59f7dc1f6dbe2ad2e805221cfce21fc2d69daaf8 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -304,13 +304,14 @@ class BrowserWindow : public BaseWindow {
// Opens the tabpose view.
virtual void OpenTabpose() = 0;
- // Sets the presentation mode for the window. If the window is not already in
- // fullscreen, also enters fullscreen mode.
- virtual void EnterPresentationMode(
+ // Enters Mac specific fullscreen mode with chrome displayed (e.g. omnibox).
+ // Enter either from non fullscreen, or from fullscreen without chrome.
+ // Exit to normal fullscreen with EnterFullscreen().
+ virtual void EnterFullscreenWithChrome(
const GURL& url,
FullscreenExitBubbleType bubble_type) = 0;
- virtual void ExitPresentationMode() = 0;
- virtual bool InPresentationMode() = 0;
+ virtual bool IsFullscreenWithChrome() = 0;
+ virtual bool IsFullscreenWithoutChrome() = 0;
#endif
// Returns the desired bounds for Instant in screen coordinates. Note that if

Powered by Google App Engine
This is Rietveld 408576698