Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: chrome/browser/ui/browser_window.h

Issue 12018007: Refactor BrowserWindow fullscreen and presentation on Mac to be consistent with other platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge TOT Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/applescript/window_applescript.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_window.h
diff --git a/chrome/browser/ui/browser_window.h b/chrome/browser/ui/browser_window.h
index d6d2fceb5b42ed6db19c2131fe855dcc93dbae6f..6cd817d46d476e5c73d019f9bab7564a15fd98e3 100644
--- a/chrome/browser/ui/browser_window.h
+++ b/chrome/browser/ui/browser_window.h
@@ -301,13 +301,14 @@ class BrowserWindow : public BaseWindow {
// Opens the tabpose view.
virtual void OpenTabpose() = 0;
- // Sets the presentation mode for the window. If the window is not already in
- // fullscreen, also enters fullscreen mode.
- virtual void EnterPresentationMode(
- const GURL& url,
- FullscreenExitBubbleType bubble_type) = 0;
- virtual void ExitPresentationMode() = 0;
- virtual bool InPresentationMode() = 0;
+ // Enters Mac specific fullscreen mode with chrome displayed (e.g. omnibox)
+ // on OSX 10.7+, a.k.a. Lion Fullscreen mode.
+ // Invalid to call on OSX earlier than 10.7.
+ // Enters either from non fullscreen, or from fullscreen without chrome.
+ // Exit to normal fullscreen with EnterFullscreen().
+ virtual void EnterFullscreenWithChrome() = 0;
+ virtual bool IsFullscreenWithChrome() = 0;
+ virtual bool IsFullscreenWithoutChrome() = 0;
#endif
// Returns the desired bounds for Instant in screen coordinates. Note that if
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/applescript/window_applescript.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698