Refactor BrowserWindow fullscreen and presentation on Mac to be consistent with other platforms.

chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_nsobject.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string_util.h"
 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
 #import "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
@@ skipping 45 matching lines @@
 - (void)enterFullscreenForURL:(const GURL&)url
                    bubbleType:(FullscreenExitBubbleType)bubbleType {
   fullscreen_ = YES;
 }
 - (void)exitFullscreen {
   fullscreen_ = NO;
 }
 - (BOOL)isFullscreen {
   return fullscreen_;
 }
+- (BOOL)inPresentationMode {
+  return false;

[Robert Sesek, 2013/01/18 19:41:35]

return NO

[scheib, 2013/01/23 18:13:37]

Done.

+}
 @end
 
 TEST_F(BrowserWindowCocoaTest, TestFullscreen) {
   // Wrap the FakeController in a scoped_nsobject instead of autoreleasing in
   // windowWillClose: because we never actually open a window in this test (so
   // windowWillClose: never gets called).
   scoped_nsobject<FakeController> fake_controller(
       [[FakeController alloc] init]);
   scoped_ptr<BrowserWindowCocoa> bwc(new BrowserWindowCocoa(
       browser(), static_cast<BrowserWindowController*>(fake_controller.get())));
 
-  EXPECT_FALSE(bwc->IsFullscreen());
-  bwc->EnterFullscreen(GURL(), FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION);
-  EXPECT_TRUE(bwc->IsFullscreen());
+  EXPECT_FALSE(bwc->IsFullscreenWithChrome());
+  EXPECT_FALSE(bwc->IsFullscreenWithoutChrome());
+  bwc->EnterFullscreenWithChrome(GURL(),
+                                 FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION);
+  EXPECT_TRUE(bwc->IsFullscreenWithChrome());
+  EXPECT_FALSE(bwc->IsFullscreenWithoutChrome());
   bwc->ExitFullscreen();
-  EXPECT_FALSE(bwc->IsFullscreen());
+  EXPECT_FALSE(bwc->IsFullscreenWithChrome());
+  EXPECT_FALSE(bwc->IsFullscreenWithoutChrome());
   [fake_controller close];
 }
 
 // Tests that BrowserWindowCocoa::Close mimics the behavior of
 // -[NSWindow performClose:].
 class BrowserWindowCocoaCloseTest : public CocoaProfileTest {
  public:
   BrowserWindowCocoaCloseTest()
       : controller_(
             [OCMockObject mockForClass:[BrowserWindowController class]]),
@@ skipping 104 matching lines @@
   [[[window_ stub] andReturn:nil] delegate];
   [[[controller_ stub] andReturn:window_] window];
   [[window_ expect] orderOut:nil];
   [[window_ expect] close];
   CreateAndCloseBrowserWindow();
   EXPECT_OCMOCK_VERIFY(controller_);
   EXPECT_OCMOCK_VERIFY(window_);
 }
 
 // TODO(???): test other methods of BrowserWindowCocoa