Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1201753004: Revert "dart2js cps: Refactor and optimize string concatenations." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
index f9f35de3fe4f87437e11cf7c01a9fc89e7e3d409..1fd6125ddab443b97f3bf2fb6653bd5d8d286059 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
@@ -364,6 +364,12 @@ class Builder implements cps_ir.Visitor<Node> {
return continueWithExpression(node.continuation, invoke);
}
+ Statement visitConcatenateStrings(cps_ir.ConcatenateStrings node) {
+ List<Expression> arguments = translateArguments(node.arguments);
+ Expression concat = new ConcatenateStrings(arguments);
+ return continueWithExpression(node.continuation, concat);
+ }
+
Statement visitThrow(cps_ir.Throw node) {
Expression value = getVariableUse(node.value);
return new Throw(value);
@@ -493,7 +499,7 @@ class Builder implements cps_ir.Visitor<Node> {
}
Expression visitConstant(cps_ir.Constant node) {
- return new Constant(node.value);
+ return new Constant(node.expression, node.value);
}
Expression visitLiteralList(cps_ir.LiteralList node) {
« no previous file with comments | « pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart ('k') | pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698