Apply outline-offset on all edges (not just top/left)

Source/core/paint/InlinePainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/InlinePainter.h"
 
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutTheme.h"
@@ skipping 81 matching lines @@
         outlineColor = Color(outlineColor.red(), outlineColor.green(), outlineColor.blue());
     }
 
     for (unsigned i = 1; i < rects.size() - 1; i++)
         paintOutlineForLine(graphicsContext, paintOffset, rects.at(i - 1), rects.at(i), rects.at(i + 1), outlineColor);
 
     if (useTransparencyLayer)
         graphicsContext->endLayer();
 }
 
+static IntRect pixelSnappedOutsetPaintRect(const LayoutRect& baseRect, const LayoutPoint& paintOffset, int outset)
+{
+    LayoutRect box(baseRect);
+    box.moveBy(paintOffset);
+    box.inflate(outset);
+    return pixelSnappedIntRect(box);
+}
+
 void InlinePainter::paintOutlineForLine(GraphicsContext* graphicsContext, const LayoutPoint& paintOffset,
     const LayoutRect& lastline, const LayoutRect& thisline, const LayoutRect& nextline, const Color outlineColor)
 {
     const ComputedStyle& styleToUse = m_layoutInline.styleRef();
     int outlineWidth = styleToUse.outlineWidth();
     EBorderStyle outlineStyle = styleToUse.outlineStyle();
 
     int offset = m_layoutInline.style()->outlineOffset();
 
-    LayoutRect box(LayoutPoint(paintOffset.x() + thisline.x() - offset, paintOffset.y() + thisline.y() - offset),
-        LayoutSize(thisline.width() + offset, thisline.height() + offset));
-
-    IntRect pixelSnappedBox = pixelSnappedIntRect(box);
+    IntRect pixelSnappedBox = pixelSnappedOutsetPaintRect(thisline, paintOffset, offset);
     if (pixelSnappedBox.width() < 0 || pixelSnappedBox.height() < 0)
         return;
     // Note that we use IntRect below for working with solely x/width values, simplifying logic at cost of a bit of memory.
-    IntRect pixelSnappedLastLine = pixelSnappedIntRect(paintOffset.x() + lastline.x() - offset, 0, lastline.width() + offset, 0);
-    IntRect pixelSnappedNextLine = pixelSnappedIntRect(paintOffset.x() + nextline.x() - offset, 0, nextline.width() + offset, 0);
+    IntRect pixelSnappedLastLine = pixelSnappedOutsetPaintRect(lastline, paintOffset, offset);
+    IntRect pixelSnappedNextLine = pixelSnappedOutsetPaintRect(nextline, paintOffset, offset);
 
     const int fallbackMaxOutlineX = std::numeric_limits<int>::max();
     const int fallbackMinOutlineX = std::numeric_limits<int>::min();
 
     // left edge
     ObjectPainter::drawLineForBoxSide(graphicsContext,
         pixelSnappedBox.x() - outlineWidth,
         pixelSnappedBox.y() - (lastline.isEmpty() || thisline.x() < lastline.x() || (lastline.maxX() - 1) <= thisline.x() ? outlineWidth : 0),
         pixelSnappedBox.x(),
         pixelSnappedBox.maxY() + (nextline.isEmpty() || thisline.x() <= nextline.x() || (nextline.maxX() - 1) <= thisline.x() ? outlineWidth : 0),
@@ skipping 81 matching lines @@
             pixelSnappedBox.maxX() + outlineWidth,
             pixelSnappedBox.maxY() + outlineWidth,
             BSBottom, outlineColor, outlineStyle,
             outlineWidth,
             outlineWidth,
             false);
     }
 }
 
 } // namespace blink