Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1201713011: DevTools: remove ruleId from the style. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove ruleId from the style. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197653

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -339 lines) Patch
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 2 3 4 7 chunks +39 lines, -101 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 3 4 36 chunks +118 lines, -235 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pfeldman
4 years, 10 months ago (2015-06-22 17:55:32 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/1201713011/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp (right): https://codereview.chromium.org/1201713011/diff/20001/Source/core/inspector/InspectorStyleSheet.cpp#newcode654 Source/core/inspector/InspectorStyleSheet.cpp:654: RefPtrWillBeRawPtr<CSSRuleSourceData> sourceData = m_sourceData; unused https://codereview.chromium.org/1201713011/diff/60001/Source/core/inspector/InspectorStyleSheet.cpp File Source/core/inspector/InspectorStyleSheet.cpp ...
4 years, 10 months ago (2015-06-23 10:26:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201713011/80001
4 years, 10 months ago (2015-06-23 12:00:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60283)
4 years, 10 months ago (2015-06-23 13:05:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201713011/80001
4 years, 10 months ago (2015-06-23 13:38:20 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 15:10:36 UTC) #11
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197653

Powered by Google App Engine
This is Rietveld 408576698