Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 12017031: infobars: Remove the downcast AsAlternateNavInfoBarDelegate() function. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, sail+watch_chromium.org
Visibility:
Public.

Description

infobars: Remove the downcast AsAlternateNavInfoBarDelegate() function. Is enough to just static_cast to the right pointer as we know at the call sites from which type the delegate is. BUG=164772 R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178015

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -15 lines) Patch
M chrome/browser/api/infobars/infobar_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/api/infobars/infobar_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/alternate_nav_infobar_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 11 months ago (2013-01-19 00:38:51 UTC) #1
Peter Kasting
LGTM
7 years, 11 months ago (2013-01-19 01:17:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12017031/1
7 years, 11 months ago (2013-01-22 13:22:49 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/infobars/alternate_nav_infobar_delegate.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-22 13:22:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/12017031/6001
7 years, 11 months ago (2013-01-22 13:33:10 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-22 15:35:09 UTC) #6
Message was sent while issue was closed.
Change committed as 178015

Powered by Google App Engine
This is Rietveld 408576698