Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chromeos/dbus/ibus/ibus_panel_service.h

Issue 12017010: Introduce bypass logic for SetCursorLocation message. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/ibus/ibus_input_context_client_unittest.cc ('k') | chromeos/dbus/ibus/ibus_panel_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/ibus/ibus_panel_service.h
diff --git a/chromeos/dbus/ibus/ibus_panel_service.h b/chromeos/dbus/ibus/ibus_panel_service.h
index 5fde186c204008c60ccb7df6cce748c350e1b5ba..7b32638fecc7f364faffbed9488b8e94d8564a65 100644
--- a/chromeos/dbus/ibus/ibus_panel_service.h
+++ b/chromeos/dbus/ibus/ibus_panel_service.h
@@ -19,6 +19,7 @@ class ObjectPath;
} // namespace dbus
namespace chromeos {
+class IBusInputContextClient;
// TODO(nona): Remove ibus namespace after complete libibus removal.
namespace ibus {
@@ -54,6 +55,8 @@ class CHROMEOS_EXPORT IBusPanelCandidateWindowHandlerInterface {
// Called when the IME hides the preedit text.
virtual void HidePreeditText() = 0;
+ // TODO(nona): Introduce SetCursorLocation function.
+
protected:
IBusPanelCandidateWindowHandlerInterface() {}
};
@@ -112,9 +115,12 @@ class CHROMEOS_EXPORT IBusPanelService {
// Factory function, creates a new instance and returns ownership.
// For normal usage, access the singleton via DBusThreadManager::Get().
+ // IBusPanelService does not take an ownership of |input_context|, so caller
+ // should release it.
static CHROMEOS_EXPORT IBusPanelService* Create(
DBusClientImplementationType type,
- dbus::Bus* bus);
+ dbus::Bus* bus,
+ IBusInputContextClient* input_context);
protected:
// Create() should be used instead.
« no previous file with comments | « chromeos/dbus/ibus/ibus_input_context_client_unittest.cc ('k') | chromeos/dbus/ibus/ibus_panel_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698