Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12017010: Introduce bypass logic for SetCursorLocation message. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, James Su, stevenjb+watch_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Introduce bypass logic for SetCursorLocation message. Current Chrome does not emit SetCursorLocation message to ibus-daemon because both candidate window and input context is in same process. It was achieved by injecting IBusClient into ui::InputMethodIBus, but we are now able to bypass them only in chromeos/ directory. With this refactoring, we can remove ui::internal::IBusClient, IBusChromeOSClientImpl and their injection code. This patch introduces bypass code for SetCursorLocation, but not used yet. BUG=None TEST=Manually done on lumpy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -65 lines) Patch
M chromeos/dbus/dbus_thread_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_constants.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.h View 5 chunks +18 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client.cc View 7 chunks +41 lines, -16 lines 0 comments Download
M chromeos/dbus/ibus/ibus_input_context_client_unittest.cc View 5 chunks +28 lines, -30 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.h View 3 chunks +7 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service.cc View 5 chunks +17 lines, -4 lines 0 comments Download
M chromeos/dbus/ibus/ibus_panel_service_unittest.cc View 4 chunks +10 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/mock_ibus_input_context_client.h View 2 chunks +7 lines, -1 line 0 comments Download
M chromeos/dbus/ibus/mock_ibus_input_context_client.cc View 3 chunks +16 lines, -1 line 0 comments Download
M ui/base/ime/ibus_client.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Seigo Nonaka
I split https://codereview.chromium.org/11956008/ into chromeos/ part and the others. This patch introduces bypass logic for ...
7 years, 11 months ago (2013-01-21 04:48:30 UTC) #1
satorux1
LGTM
7 years, 11 months ago (2013-01-22 07:10:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12017010/1
7 years, 11 months ago (2013-01-22 08:23:58 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-22 10:41:34 UTC) #4
Message was sent while issue was closed.
Change committed as 177995

Powered by Google App Engine
This is Rietveld 408576698