Issue 120163005: Make tab tooltip behavior consistent across all desktop platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 120163005: Make tab tooltip behavior consistent across all desktop platforms. (Closed)

Created:
6 years, 11 months ago by miu

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make tab tooltip behavior consistent across all desktop platforms. All desktop platforms now show the tab tooltip on mouse hover, regardless of whether the page title text entirely fits within a tab. Also, fixed a subtle bug where View::TooltipTextChanged() was not being called when the data model was changed. This allows a tooltip to be updated while still hovering over the tab with the mouse. BUG=310947 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243411

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -18 lines)			Patch
	M	chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/views/tabs/tab.cc	View		2 chunks	+7 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/120163005/30001

6 years, 11 months ago (2014-01-07 18:38:18 UTC) #3

Message was sent while issue was closed.

Change committed as 243411

Expand Messages | Collapse Messages