Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Unified Diff: cc/test/scheduler_test_common.cc

Issue 1201573002: cc: Remove BeginFrameSourcesConstructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/scheduler_test_common.cc
diff --git a/cc/test/scheduler_test_common.cc b/cc/test/scheduler_test_common.cc
index 31b0721b825c4c42f3f2d9f8dc80497b1d14583d..870de69a86ef33881b93a84ee2dddcccbf524b61 100644
--- a/cc/test/scheduler_test_common.cc
+++ b/cc/test/scheduler_test_common.cc
@@ -64,50 +64,24 @@ TestSyntheticBeginFrameSource::TestSyntheticBeginFrameSource(
TestSyntheticBeginFrameSource::~TestSyntheticBeginFrameSource() {
}
-TestSchedulerFrameSourcesConstructor::TestSchedulerFrameSourcesConstructor(
- OrderedSimpleTaskRunner* test_task_runner,
- base::SimpleTestTickClock* now_src)
- : test_task_runner_(test_task_runner), now_src_(now_src) {
-}
-TestSchedulerFrameSourcesConstructor::~TestSchedulerFrameSourcesConstructor() {
-}
-
-BeginFrameSource*
-TestSchedulerFrameSourcesConstructor::ConstructPrimaryFrameSource(
- Scheduler* scheduler) {
- if (scheduler->settings_.use_external_begin_frame_source) {
- return SchedulerFrameSourcesConstructor::ConstructPrimaryFrameSource(
- scheduler);
- } else {
- TRACE_EVENT1(
- "cc",
- "TestSchedulerFrameSourcesConstructor::ConstructPrimaryFrameSource",
- "source",
- "TestSyntheticBeginFrameSource");
- scoped_ptr<TestSyntheticBeginFrameSource> synthetic_source =
- TestSyntheticBeginFrameSource::Create(
- now_src_, test_task_runner_, BeginFrameArgs::DefaultInterval());
-
- DCHECK(!scheduler->vsync_observer_);
- scheduler->vsync_observer_ = synthetic_source.get();
-
- DCHECK(!scheduler->primary_frame_source_internal_);
- scheduler->primary_frame_source_internal_ = synthetic_source.Pass();
- return scheduler->primary_frame_source_internal_.get();
+scoped_ptr<TestScheduler> TestScheduler::Create(
+ base::SimpleTestTickClock* now_src,
+ SchedulerClient* client,
+ const SchedulerSettings& settings,
+ int layer_tree_host_id,
+ OrderedSimpleTaskRunner* task_runner,
+ BeginFrameSource* external_frame_source) {
+ scoped_ptr<TestSyntheticBeginFrameSource> synthetic_frame_source;
+ if (!settings.use_external_begin_frame_source) {
+ synthetic_frame_source = TestSyntheticBeginFrameSource::Create(
+ now_src, task_runner, BeginFrameArgs::DefaultInterval());
}
-}
-
-BeginFrameSource*
-TestSchedulerFrameSourcesConstructor::ConstructUnthrottledFrameSource(
- Scheduler* scheduler) {
- TRACE_EVENT1(
- "cc",
- "TestSchedulerFrameSourcesConstructor::ConstructUnthrottledFrameSource",
- "source", "TestBackToBackBeginFrameSource");
- DCHECK(!scheduler->unthrottled_frame_source_internal_);
- scheduler->unthrottled_frame_source_internal_ =
- TestBackToBackBeginFrameSource::Create(now_src_, test_task_runner_);
- return scheduler->unthrottled_frame_source_internal_.get();
+ scoped_ptr<TestBackToBackBeginFrameSource> unthrottled_frame_source =
+ TestBackToBackBeginFrameSource::Create(now_src, task_runner);
+ return make_scoped_ptr(new TestScheduler(
+ now_src, client, settings, layer_tree_host_id, task_runner,
+ external_frame_source, synthetic_frame_source.Pass(),
+ unthrottled_frame_source.Pass()));
}
TestScheduler::TestScheduler(
@@ -115,15 +89,17 @@ TestScheduler::TestScheduler(
SchedulerClient* client,
const SchedulerSettings& scheduler_settings,
int layer_tree_host_id,
- const scoped_refptr<OrderedSimpleTaskRunner>& test_task_runner,
- TestSchedulerFrameSourcesConstructor* frame_sources_constructor,
- scoped_ptr<BeginFrameSource> external_begin_frame_source)
+ OrderedSimpleTaskRunner* task_runner,
+ BeginFrameSource* external_frame_source,
+ scoped_ptr<TestSyntheticBeginFrameSource> synthetic_frame_source,
+ scoped_ptr<TestBackToBackBeginFrameSource> unthrottled_frame_source)
: Scheduler(client,
scheduler_settings,
layer_tree_host_id,
- test_task_runner,
- external_begin_frame_source.Pass(),
- frame_sources_constructor),
+ task_runner,
+ external_frame_source,
+ synthetic_frame_source.Pass(),
+ unthrottled_frame_source.Pass()),
now_src_(now_src) {
}

Powered by Google App Engine
This is Rietveld 408576698