Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1201563004: Revert of Handle typographical apostrophe with spelling service client (Closed)

Created:
5 years, 6 months ago by please use gerrit instead
Modified:
5 years, 6 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org, Julius
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Handle typographical apostrophe with spelling service client (patchset #9 id:260001 of https://codereview.chromium.org/1092243002/) Reason for revert: Suspected to be causing crashes in http://crbug.com/502786. Original issue's description: > Handle typographical apostrophe with spelling service client > > Do not mark typographical apostrophe as misspelled, if the server wants > to replace it with a typewriter apostrophe. > > TEST=SpellCheckTest.CreateTextCheckingResults > TEST=SpellCheckTest.IsValidContraction > TEST=SpellcheckWordIteratorTest.TypographicalApostropheIsPartOfWord > TEST=SpellingServiceClientTest.RequestTextCheck > BUG=165079 > > Committed: https://crrev.com/e12b92b09e5aa238758e3f2f0d7c195709fbf217 > Cr-Commit-Position: refs/heads/master@{#335193} TBR=groby@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=165079 Committed: https://crrev.com/34bece1d38a9fec7e6903eceff8c75aea3b153e7 Cr-Commit-Position: refs/heads/master@{#335454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -262 lines) Patch
M chrome/browser/spellchecker/spelling_service_client.cc View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client_unittest.cc View 16 chunks +18 lines, -45 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 2 chunks +28 lines, -62 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 6 chunks +3 lines, -96 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator_unittest.cc View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Created Revert of Handle typographical apostrophe with spelling service client
5 years, 6 months ago (2015-06-21 18:11:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201563004/1
5 years, 6 months ago (2015-06-21 18:11:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-21 18:11:51 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-21 18:12:40 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34bece1d38a9fec7e6903eceff8c75aea3b153e7
Cr-Commit-Position: refs/heads/master@{#335454}

Powered by Google App Engine
This is Rietveld 408576698