Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1201543002: Atomic operations on Uint8ClampedArray (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Atomic operations on Uint8ClampedArray BUG=chromium:497295 R=jarin@chromium.org LOG=n Committed: https://crrev.com/5b3700a49a403963e64fd44b529021130458b452 Cr-Commit-Position: refs/heads/master@{#29199}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -161 lines) Patch
M src/runtime/runtime-atomics.cc View 10 chunks +113 lines, -4 lines 2 comments Download
M test/mjsunit/harmony/atomics.js View 10 chunks +129 lines, -157 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
binji
5 years, 6 months ago (2015-06-20 01:38:14 UTC) #1
Jarin
lgtm. https://codereview.chromium.org/1201543002/diff/1/src/runtime/runtime-atomics.cc File src/runtime/runtime-atomics.cc (right): https://codereview.chromium.org/1201543002/diff/1/src/runtime/runtime-atomics.cc#newcode433 src/runtime/runtime-atomics.cc:433: return value; Hmm, I am really surprised this ...
5 years, 6 months ago (2015-06-22 07:04:04 UTC) #2
binji
https://codereview.chromium.org/1201543002/diff/1/src/runtime/runtime-atomics.cc File src/runtime/runtime-atomics.cc (right): https://codereview.chromium.org/1201543002/diff/1/src/runtime/runtime-atomics.cc#newcode433 src/runtime/runtime-atomics.cc:433: return value; On 2015/06/22 at 07:04:03, jarin wrote: > ...
5 years, 6 months ago (2015-06-22 18:21:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201543002/1
5 years, 6 months ago (2015-06-22 18:21:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3619)
5 years, 6 months ago (2015-06-22 18:40:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201543002/1
5 years, 6 months ago (2015-06-22 18:42:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 18:51:14 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 18:51:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b3700a49a403963e64fd44b529021130458b452
Cr-Commit-Position: refs/heads/master@{#29199}

Powered by Google App Engine
This is Rietveld 408576698