Turn on wavy underlines. The waves aren't very pretty yet (they are too short somehow), I'll fix th…

Turn on wavy underlines. The waves aren't very pretty yet (they are too short somehow), I'll fix that in a subsequent CL.

I abstracted out the wavy underline code so that it doesn't duplicate the code for horizontal and vertical lines.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/ed26a0e0333ab961c704783f18002d0c3db4ab30

[abarth-chromium, 2015-06-19 23:00:45]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-19 23:00:46]

lgtm

https://codereview.chromium.org/1201503003/diff/1/sky/engine/core/rendering/I...
File sky/engine/core/rendering/InlineTextBox.cpp (right):

https://codereview.chromium.org/1201503003/diff/1/sky/engine/core/rendering/I...
sky/engine/core/rendering/InlineTextBox.cpp:803: static inline void
setX(FloatPoint& p, double x) { p.setX(x); }
const FloatPoint& for y, x, and setX.

(Also, I would put x before y.)

https://codereview.chromium.org/1201503003/diff/1/sky/engine/core/rendering/I...
sky/engine/core/rendering/InlineTextBox.cpp:810: static inline void
setX(FloatPoint& p, double x) { p.setY(x); }
ditto

https://codereview.chromium.org/1201503003/diff/1/sky/engine/core/rendering/I...
sky/engine/core/rendering/InlineTextBox.cpp:848: template <class T> static void
strokeWavyTextDecorationInternal(GraphicsContext* context, FloatPoint p1,
FloatPoint p2, float strokeThickness)
s/T/Curve/ for readability.

https://codereview.chromium.org/1201503003/diff/1/sky/engine/core/rendering/I...
sky/engine/core/rendering/InlineTextBox.cpp:866: x2 = T::x(p2);
Should we give these more semantic names, like |main| and |cross| ?

[Hixie, 2015-06-19 23:11:22]

Committed patchset #1 (id:1) manually as
ed26a0e0333ab961c704783f18002d0c3db4ab30 (presubmit successful).