Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Issue 1201393003: Unflake http/tests/xmlhttprequest/event-listener-gc.html (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Unflake http/tests/xmlhttprequest/event-listener-gc.html Using a zero-timeout and timer task to set up the test condition is not as precise as we would like. Rephrase to use an immediate message dispatch instead. R= BUG=503842 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197724

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M LayoutTests/http/tests/xmlhttprequest/event-listener-gc.html View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-24 07:47:26 UTC) #2
tyoshino (SeeGerritForStatus)
On 2015/06/24 07:47:26, sof wrote: > please take a look. postMessage() is the best way ...
5 years, 6 months ago (2015-06-24 09:42:57 UTC) #3
sof
On 2015/06/24 09:42:57, tyoshino wrote: > On 2015/06/24 07:47:26, sof wrote: > > please take ...
5 years, 6 months ago (2015-06-24 09:45:11 UTC) #4
tyoshino (SeeGerritForStatus)
On 2015/06/24 09:45:11, sof wrote: > On 2015/06/24 09:42:57, tyoshino wrote: > > On 2015/06/24 ...
5 years, 6 months ago (2015-06-24 09:46:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1201393003/1
5 years, 6 months ago (2015-06-24 09:47:27 UTC) #7
tyoshino (SeeGerritForStatus)
Promise.resolve().then(collect); should work too?
5 years, 6 months ago (2015-06-24 09:48:49 UTC) #8
tyoshino (SeeGerritForStatus)
On 2015/06/24 09:48:49, tyoshino wrote: > Promise.resolve().then(collect); should work too? Hmm, microtask is not so ...
5 years, 6 months ago (2015-06-24 09:49:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197724
5 years, 6 months ago (2015-06-24 09:51:12 UTC) #10
sof
5 years, 6 months ago (2015-06-24 09:56:25 UTC) #11
Message was sent while issue was closed.
On 2015/06/24 09:49:37, tyoshino wrote:
> On 2015/06/24 09:48:49, tyoshino wrote:
> > Promise.resolve().then(collect); should work too?
> 
> Hmm, microtask is not so reliable for this purpose for now?

Or requestAnimationFrame(collect) (or some setImmediate() thing, should that
transpire.)

I don't think it is possible to guarantee expected ordering 100% here -- i.e.,
triggering the GC after OPENED (but without having the XHR object on the stack
while doing that GC), but before other readystate transitions.

Powered by Google App Engine
This is Rietveld 408576698